Repository navigation
fix(builder): constrain the Show details hit area - #1863
Conversation
Record the offscreen WPF reproduction for NotRexed#1842 before the localized layout fix. Blank-space hits reproduce at two widths; label and Cancel controls pass. Assisted-by: OpenAI Codex Co-Authored-By: Codex <noreply@openai.com>
Align only ShowLog to its content so the blank footer column no longer opens the log. Exercise actual production WPF resources, fonts and footer geometry at two widths; preserve label and Cancel hit testing and identical rendered pixels. Fixes NotRexed#1842 Assisted-by: OpenAI Codex Co-Authored-By: Codex <noreply@openai.com>
hckrman101
left a comment
There was a problem hiding this comment.
Looks good. HorizontalAlignment="Left" on ShowLog is the right minimal fix: the button was stretching across the Star column, and Cancel sits in the Auto column so it's untouched. I checked the XAML against main and the ShowLog element is unchanged there apart from this attribute, the worklist row is in the right place and format, and the new test's {dotnet} placeholder and linux skip are valid for run_all.py. CI is all green (the Windows source suite is the one that actually runs the WPF fixture).
Nit, non-blocking: test_builder_details_hitbox.py reads builder_details_hitbox_test.cs from ROOT rather than args.source, while the XAML comes from --source. It only matters if someone points --source at another checkout.
Good to merge.
The worklist was behind the forum and the merges. Since v2.1.0, many fix PRs have merged, several rows already shipped, and the most-reported problems in Discord #bug-reporting had no row. This PR brings `docs/worklist.md` back in line, following the rules in the worklist and in `docs/workflow.md`. ## Method - **Forum snapshot.** All 409 #bug-reporting posts as of Nov 11, ~11:10 PM ET (Nov 7-11). Each post is dated by its thread ID, so the submit time is in ET. - **How dates were used.** - v2.1.0 was cut from `main` at about 8:32 PM ET on Nov 10 and published at 9:29 PM ET. A PR merged before the cut counts as shipped; I checked this with `git merge-base --is-ancestor <merge commit> v2.1.0`. - A report sent before a fix shipped and not repeated after it counts as fixed. - A report sent after v2.1.0, or before a fix that merged later, counts as still open or waiting for a release. - **Score.** Severity x reach x confidence. - Reach comes from workflow.md's 2026-11-10 reporter shares. Where the affected subset is unknown, it is marked as an upper bound. - Confidence is 0.7 only where the GitHub tracker has logs from several commenters; otherwise it is 0.4. - **Owners.** New rows have no owner. Existing owners are kept. ## Changes - **Added 20 rows (18 Open, 2 Fixed-waiting).** - Open: RAM/VRAM fill-up to OOM (#993, 5.6; 13 threads after v2.1.0), shader preparation stalls (3.2), AMD Windows crashes (#996, 2.9), CPU-bound fps in Castle Town and Hyrule Field (#995), invisible objects and doors (#1002), build.py stopped on v2.1.0, cutscene audio desync, shadow artifacts, coloured lighting, HDR black screen and flicker, frame generation stutter, the block grid around lights and fog, the v2.1.0 update failing, AF outlines, wrong button glyphs, Steam Deck at 6 fps, Linux AMD slower than Windows, and the FSR 4 tick not rebuilding. - Fixed-waiting: the pick-up counter above 60 fps (#2006) and RADV device lost after the intro (#2362). - **Updated 6 rows.** - The Link-jump row is now the "above a 60 fps cap" row (#1742), covering the Scarecrow's Song softlock, Gohma and the item hanging above Link's head. It goes from S2 to S1 and is re-scored from 1.2 to 3.5. - New forum links or scores on the antivirus, Intel black screen (0.11 to 0.2, #999 has logs), fairy grotto, voices (#2506) and RX 580 (#2343) rows. - **Moved 10 rows to Fixed, waiting for a release.** #2545 (ground garbling), #2451 (RTX 30 crash), #2286, #2275, #2449, #2096, #2406, #2515, #1954 and #2367. - **Deleted 8 rows** whose fix shipped in v2.1.0: #1792, #1922, #1819, #1863, #1447, #1451, #1769-#1810 and the HDR10 overlay. ## Not done - PRs listed as "candidate" fixes are matched by title and description only. None is confirmed against the reports. - Long forum threads were judged from their summaries. - `tests/run_all.py` was not run (docs-only change). Co-authored-by: Joey Magnus <joey.magnus@cxalloy.com>
Clicking blank space beside Show details currently toggles the Builder log because its transparent button stretches across the footer column. Align the individual button to the left so its hit area follows the label while Cancel retains its existing target. The shared Link style is unchanged.
Fixes #1842.
Validation:
117eae79, including fix(vk): present ahead's vk_replay.cpp half, lost in #1720's merge (main doesn't link) #1858's presentation link repair and tests: fix four source checks broken on main (PREPARE fixture; ini_key renames; long-path out-of-space folder; DrawParameters Ctx) #1793's shared source-check repairs, is merged normally. Both merges leave the tested Builder, fixture and runner inputs unchanged.An independent review found no material issues and confirmed that the relevant files still match the verification receipt. All eight hosted checks now pass on current head
1e67b68f: Windows/Linux source suites, Windows Builder packaging, Windows Vulkan, Linux AppImage, both native lowering checks and workflow lint. Release-upload jobs are correctly skipped for a pull request. The WPF fixture runs on Windows; its Linux skip reflects the native platform requirement.Gaps: no DPI, RTL/localization, keyboard-navigation or full-window state-transition validation. The full suite was not run locally because an existing owner-imposed stop excludes a shader fixture; both hosted source suites and packaging pass.