Repository navigation
fix(shaders): ISBERD.O, a task program reading back its payload (12 failing pipelines) - #1789
Merged
Merged
Conversation
…t region One of OoT's task programs reads its own payload (ISBERD.32.ATTR.O) and stopped as "native stage buffer access mode": the lowering took reads from the input region only. The nx2 pseudo instruction already carries .O (bit 47); the frontend now reads it as a new IsbeReadOutput, which the SPIR-V back end loads from the word IsbeWriteAttribute writes: the task payload, or the mesh's shared attributes. Writes stay output-only, reads attribute-region only. The opcode tables grow to 543. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # tests/run_all.py
This was referenced Nov 10, 2026
# Conflicts: # tests/run_all.py
Joey-Magnus
pushed a commit
to Joey-Magnus/Hookshot
that referenced
this pull request
Nov 10, 2026
…ed#1778 NotRexed#1789 NotRexed#1800 NotRexed#1806 NotRexed#1810 merged): to Fixed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of OoT's task programs fails to translate ("does not lower ... native stage buffer access mode") because it reads back its own task payload, and the lowering only took stage-buffer reads from the input region. Its mesh pipelines are behind 12 of the 17 programs that still fail in the startup pipeline build, so whatever they draw is missing on every PC.
The instruction (program
64ba846654e63ea4, task stage, +0x80):Bits 75 (.32), 76-77 = 3 (.ATTR) and 79 (.O, the output buffer). The program reads word 4 of its payload, which it writes with ISBEWR.O.
Change
lower_to_maxwell.h(0x923/0x927): a read may now be of the output region. Writes are still always to it, and reads still only from the attribute region. The nx2 pseudo instruction already carries .O in bit 47.internal_stage_buffer_entry_read.cpp:ISBE_nx2decodes bit 47, and a read with it becomes the new IR opIsbeReadOutput.emit_spirv_mesh.cpp:EmitIsbeReadOutputloads the wordEmitIsbeWriteAttributestores there:PayloadWord(index)in a task program, the shared attribute array (clamped, as the write) in a mesh program.opcodes.inc/ir_emittergainIsbeReadOutput. The hand-sized opcode tables inopcodes.cpp/opcodes.hgo to 543 (test_lower_atomg_cas.pychecks that).Tests
tests/test_lower_isberd_output.py(inrun_all.py): the log's ISBERD.O lowers to the pseudo instruction with .O. Without .O it's the input read as before. .O on the map region is refused, ISBEWR without .O is refused, and ISBEWR.O lowers as before. It fails onmainand passes here.run_all.py: all pass exceptnx2/test_nup_stand_in.py, which fails onmaintoo (a separate break I'm looking at).No screenshot yet: I haven't identified which effect these task/mesh pipelines draw.
🤖 Generated with Claude Code