Repository navigation
fix: keep pressed tooltips hidden and make sidebar rows contiguous - #119
Merged
Merged
Conversation
This was referenced Oct 14, 2026
kirillDevPro
added a commit
that referenced
this pull request
Oct 16, 2026
What was stale: MOON_PATCH_QUEUE lists the Moon GPUI patches a Zed re-sync must keep, but the tooltip entry described only the 800 ms show delay, the five-second expiry and hoverable persistence. #119 (0c4a7c4) added a Moon-only behaviour that a re-sync would silently drop. What the code does now: a mouse press on a regular tooltip's trigger replaces its state with SuppressedUntilMouseLeaves (hiding it or cancelling a pending show); TooltipTrigger::check_can_show gates showing while check_is_hovered alone clears the suppression once the pointer leaves, even with the button held. Upstream only cleared the tooltip on press and let the next pointer move after release schedule it again. Verified against crates/moon-gpui/src/elements/div.rs (register_tooltip_mouse_handlers, handle_tooltip_mouse_move) and the pre-change code in 0c4a7c4^. cargo xtask component-mirror and component-audit --check-baseline both PASS. Reviewer: Codex. It disputed the first wording of the upstream sentence (release does not itself reschedule; the next pointer move does); the sentence was corrected to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
WaitingForShow) tooltip alive, so a right-click that opens a context menu was followed half a second later by the cell's tooltip drawn over the menu. A press over the trigger now moves the tooltip toSuppressedUntilMouseLeaves, cancelling a pending show and hiding a visible non-hoverable one; leaving the trigger re-arms it. Hoverable tooltips and presses elsewhere are unchanged.SidebarMenuspaced items withgap_2while each item's click covered only its inner 28 px plate, leaving dead strips between items. The spacing now lives inside each item as padding, so hit rows are contiguous; the visible plate, pitch and look are unchanged (collapsed layout too).How to verify
Tests: new regressions in
elements/div/tests.rsandsidebar/menu/tests.rs;moon-gpuiandmoon-ui-componentssuites green locally. Both behaviours checked in a downstream app build.