Skip to content

fix: smooth filter-line hover, draw the open candle's 5-second path, pick up MoonUI fixes - #973

Merged
kirillDevPro merged 3 commits into
mainfrom
fix/filter-hover-open-candle
Oct 14, 2026
Merged

kirillDevPro merged 3 commits into
mainfrom
fix/filter-hover-open-candle

Conversation

@kirillDevPro

Copy link
Copy Markdown
Collaborator

What & why

  • Filter-line hover (chart captions). Hit zones used the glyph box height, taller than the line pitch, so neighbouring zones overlapped and two lines lit at once; the tint was computed from the panel's cached cursor at render time and lagged the pointer. Zones now span exactly one line pitch and the tint is GPUI hover styling.
  • Open candle's 5-second path (Open candle is blank left of the live ticks — draw the 5-second path the core already sent #962). With recent candles hidden, the open bucket on a wide timeframe stayed empty left of the raw trade dots. The core already sends its folded 5-second mini-candles; they are kept left of the oldest raw dot and drawn inside the hidden bucket with the user's candle style on DX11, Metal and wgpu. The hide rule, raw dots, volume band and live follow are unchanged.
  • MoonUI pin → 0c4a7c4 (fix: keep pressed tooltips hidden and make sidebar rows contiguous MoonUI#119): a press on a tooltip's trigger keeps the tooltip hidden (no tooltip over a just-opened context menu), and sidebar menu rows have no dead gaps between items.

Closes #962

How to verify

  • Hover the strategy-filter lines in a chart caption: exactly one line lights, following the pointer.
  • 1д candles + trades with hidden recent candles: the open day shows the 5-second path up to the raw dots.
  • Report: right-click a coin cell — no tooltip over the menu. Settings: a click between two nav items selects one.

Local checks on this branch: cargo fetch --locked, cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace (7132 passed). Metal and wgpu paths are not compiled locally (macOS probe in CI).

Filter-line hit zones used the glyph box height, taller than the line
pitch, so neighbouring zones overlapped and two lines lit at once. The
hover tint was also computed from the panel's cached cursor at render
time, so it lagged the pointer. Zones now span exactly one line pitch
and the tint is GPUI hover styling.
… stretch (#962)

With recent candles hidden, the open bucket stayed empty left of the raw
trade dots on wide timeframes. The core already sends its folded 5-second
mini-candles; they are now kept left of the oldest raw dot and drawn in
the hidden bucket with the user's candle style, on DX11, Metal and wgpu.
The hide rule, the dots, the volume band and live follow are unchanged.
@kirillDevPro
kirillDevPro merged commit 9bee421 into main Oct 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open candle is blank left of the live ticks — draw the 5-second path the core already sent

1 participant