Repository navigation
chore(sidebar): refresh reviewed mirror metadata - #120
Merged
Merged
Conversation
The sidebar hit-row change landed without regenerating its mirror entry, so the Component guardrails job fails on master with a changed sidebar local hash. Regenerate only the sidebar entry; the drift budget still holds.
The contiguous hit-row change adds group.rs and the sibling menu tests to the donor-different set, so the component audit reports 5 > 3. Raise only the sidebar budget and name the reason in fork_reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Master fails Component guardrails: the sidebar change in #119 did not regenerate its mirror entry (
sidebar local hash changed: 7cced9c0920e2e8f -> 0eeeac4e89296fa8). This regenerates only the sidebar entry indocs/component-mirror-baseline.json.How to verify
cargo xtask component-mirror --donor-root vendor/longbridge-gpui-component-ui-src --check-baseline-> PASS.