Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 16, 2026
Owner
Author
|
Closing because CodSpeed did not confirm a performance improvement, and the callback extraction is not needed on its own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
MultipartParser'sdata_callbackclosure into_data_callback, withdataandlengthpassed explicitly instead of captured on eachwrite(). This takes one part of the proposal in #368, leaving the header-size checks and other closures unchanged. Pin the benchmark workflow to Python 3.13.18, the patch release used by the initial CI run, to prevent interpreter drift.Add a public-API regression test for callback order and data across chunk boundaries, including failed boundary matches. Validation:
scripts/check,scripts/test --strict-config --strict-markers(217 tests, 100% coverage), andscripts/renamepass.Local microbenchmarks on CPython 3.13.4, macOS arm64 (µs per parse; median of three interleaved comparisons, each taking the best of seven
timeitbatches with the existing benchmark inputs):mainThese are local microbenchmark results, not end-to-end request timings. The initial CodSpeed simulation reported no performance change across all five benchmarks, so a portable speedup is not established.
Session:
pi --session 01a1e0a2-78a9-7473-86ce-b992bd92cf74