Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Closing because CodSpeed did not confirm a performance improvement for the helper version. The inlined variant was not pushed or measured in CI, so no speedup is established for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
advance_header_sizeclosure with inline counter increments and a shared_check_header_size(size, offset)method. This keepsiandcurrent_header_sizeas ordinary locals without duplicating validation or changing when errors are raised.This targets
mainafter #370, independently of #369. Callback handling and workflows are unchanged. Use the existing CodSpeed benchmarks to check whether this isolated change improves performance; no speedup is assumed.Add public-API tests for limits in header names, leading spaces, and values, including exact limits, split writes, error offsets, and size-check-before-validation ordering. The new cases also pass against unchanged
main.Validation on Python 3.13.18:
scripts/check,scripts/test --strict-config --strict-markers(201 tests, 100% coverage), andscripts/renamepass.Session:
pi --session 01a1e0a2-78a9-7473-86ce-b992bd92cf74