Repository navigation
Inline multipart mark operations - #370
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR now stands alone against
main; it does not require #369 to merge first. The earlier stacked changes are reverted in a new commit to preserve pushed history.Replace
set_markanddelete_markwith the sameself.marksassignments andpop(..., None)calls, avoiding two function creations perwrite(). The net diff changes onlypython_multipart/multipart.py; callback extraction, header-size validation, tests, and workflows are unchanged frommain.Validation on Python 3.13.18:
scripts/check,scripts/test --strict-config --strict-markers(185 tests, 100% coverage), andscripts/renamepass.Local wall-clock microbenchmarks on CPython 3.13.18, macOS arm64, using the existing benchmark inputs (µs per parse; median of three interleaved comparisons, each taking the best of seven
timeitbatches):main(9bd038e)These small local differences do not establish a portable speedup; CodSpeed is the independent check.
Additional
-W errortesting exposes pre-existing unclosed-file warnings intest_upload_dir_with_leading_slash_in_filename,test_file_full_name, andtest_file_full_name_with_ext. The same failures reproduce onmain(9bd038e) with Python 3.13.18; they are not changed here.Session:
pi --session 01a1e0a2-78a9-7473-86ce-b992bd92cf74