Skip to content

requirements: Fix zulint egg fragment and ignore empty lines in rss-bot #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anikethinge wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

requirements: Fix zulint egg fragment and ignore empty lines in rss-bot #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7ffc8
requirements: Fix invalid egg fragment specifier for zulint.
anikethinge Oct 14, 2026
b5c635c
rss-bot: Ignore empty lines and comments in feed files.
anikethinge Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ruff~=0.2.2
-e ./zulip
-e ./zulip_bots
-e ./zulip_botserver
git+https://github.com/zulip/zulint@417b4e4971fdd5ca8e84847f1391b657b188631a#egg=zulint==1.0.0
git+https://github.com/zulip/zulint@417b4e4971fdd5ca8e84847f1391b657b188631a#egg=zulint
mypy==1.8.0
types-httplib2
types-python-dateutil
Expand Down
6 changes: 5 additions & 1 deletion zulip/integrations/rss/rss-bot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,11 @@ def send_zulip(entry: Any, feed_name: str) -> Dict[str, Any]:

try:
with open(opts.feed_file) as f:
feed_urls: List[str] = [feed.strip() for feed in f.readlines()]
feed_urls: List[str] = [
feed.strip()
for feed in f.readlines()
if feed.strip() and not feed.strip().startswith("#")
]
except OSError:
log_error_and_exit(f"Unable to read feed file at {opts.feed_file}.")

Expand Down
Loading