Repository navigation
requirements: Fix zulint egg fragment and ignore empty lines in rss-bot - #929
Open
anikethinge wants to merge 2 commits into
Open
anikethinge wants to merge 2 commits into
anikethinge wants to merge 2 commits into
Conversation
Modern versions of pip (pip 25+) reject version specifiers inside #egg= fragments with invalid-egg-fragment. Remove ==1.0.0 from the zulint URL in requirements.txt.
anikethinge
force-pushed
the
fix-zulint-egg-fragment
branch
2 times, most recently
from
October 22, 2026 05:07
31b35b5 to
4a3b4dd
Compare
Author
|
This PR includes two fixes:
|
anikethinge
changed the title
anikethinge
force-pushed
the
fix-zulint-egg-fragment
branch
2 times, most recently
from
October 22, 2026 05:35
40c5066 to
857e7be
Compare
anikethinge
force-pushed
the
fix-zulint-egg-fragment
branch
from
October 22, 2026 09:08
857e7be to
ab7ffc8
Compare
Fixes zulip#920 by filtering out empty lines and lines starting with '#' when reading the feed configuration file.
anikethinge
force-pushed
the
fix-zulint-egg-fragment
branch
from
October 23, 2026 10:41
9e93f71 to
b5c635c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern versions of
pip(pip 25+ / Python 3.14) reject version specifiers inside#egg=fragments witherror: invalid-egg-fragment.This removes the redundant
==1.0.0version specifier from#egg=zulint==1.0.0inrequirements.txtsopip install -r requirements.txtsucceeds on newer pip versions.