Skip to content

Fix restore selector spacing and mobile safe areas - #31

Merged
vrtmrz merged 1 commit into
mainfrom
fix/restore-selector-safe-area
Nov 4, 2026
Merged

vrtmrz merged 1 commit into
mainfrom
fix/restore-selector-safe-area

Conversation

@vrtmrz

@vrtmrz vrtmrz commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Fixes the Restore from Backup revision selector extending into mobile safe areas and losing Obsidian's native content spacing.

Changes

  • Mount the selector in Obsidian's standard modal content area, preserving native padding, the title, and the Close control.
  • Reserve mobile safe areas and keyboard space, and let search inputs and revision columns fit the available width.
  • Add real-Obsidian regression coverage for portrait, landscape, simulated keyboard height, native content spacing, horizontal overflow, touch targets, and native Close behaviour.

Verification

  • The new assertions reproduced the original safe-area overlap (23.5px at the top and 10.5px at the bottom), missing native padding, and list overflow before the corresponding fixes; they pass afterwards.
  • Real Obsidian 1.12.7 on Linux arm64 under Xvfb: selector/restore-confirmation and mirror-delete-semantics E2E passed.
  • Restore selector UI tests: 8 passed with one worker.
  • Production build, E2E TypeScript check, formatting, and git diff --check passed.
  • Community lint: 0 errors and 49 existing warnings; the build retains the existing Svelte initialItems warning.
  • Build behaviour verified by the maintainer.

@vrtmrz
vrtmrz changed the base branch from chore/dependency-audit-updates to main November 4, 2026 06:05
@vrtmrz
vrtmrz merged commit 6de1804 into main Nov 4, 2026
1 check passed
@vrtmrz vrtmrz mentioned this pull request Nov 4, 2026
3 tasks done
@vrtmrz
vrtmrz deleted the fix/restore-selector-safe-area branch November 4, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant