Repository navigation
fix(sveltekit): use afterNavigate for SvelteKit 2 and 3 - #215
Open
CNSeniorious000 wants to merge 4 commits into
Open
CNSeniorious000 wants to merge 4 commits into
CNSeniorious000 wants to merge 4 commits into
Conversation
|
@CNSeniorious000 is attempting to deploy a commit to the Analytics Test Projects Team on Vercel. A member of the Team first needs to authorize it. |
Open
$app/stores with $app/state for SvelteKit 3This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SvelteKit 3 removed the
$app/storesmodule.injectAnalyticsimportedpagefrom it and calledpage.subscribe(), which throws at runtime:This crashes hydration for any SvelteKit 3 app using
injectAnalytics.Fix
afterNavigatefrom$app/navigationto observe completed navigations without patching the global History API/sveltekitentry and updatepeerDependenciesto^2.12 || ^3injectAnalyticsfrom a component initialization, as required by SvelteKit'safterNavigatelifecycle APIsrc/routes/+layout.svelteafterNavigateis available in SvelteKit 2.12 and 3. Its callback receives the completed destination, so page views use the final{ route, path }values.Notes
$app/environmentis still used forbrowser; it is deprecated in SvelteKit 3 but not removed until SvelteKit 4injectAnalyticsduring component initialization, for example from+layout.svelte