Repository navigation
fix: reliable upload and doctor exit statuses - #1
Merged
Merged
Conversation
sunxiuguo
marked this pull request as ready for review
October 5, 2026 02:13
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MiniprogramCi.upload().Verification
npm ci --cache /tmp/miniprogram-deploy-npm-cache --no-audit --no-fund: passed.npm test: passed, 23 tests on Node.js 24.19.0. Includes schema regeneration and TypeScript compilation.git diff --checkand JavaScript syntax checks: passed.f69ff7830a855b49c00eb62de6ab2856f79060e5: test run.Scope and limitations
Tests replace the WeChat SDK, Git, and interactive input in isolated child processes. No real credentials are read and no real WeChat uploads are performed. Actual SDK/service compatibility still requires an authorized integration environment. The legacy SDK's worker managers use 10-second idle cleanup timers; the process may remain alive while those workers finish. Real SDK background-network shutdown is outside the mocked test suite.
This change keeps the current SDK/dependency versions, lockfile, package version, and ISC declaration. It does not publish an npm release.
中文说明
修复上传成功仍返回失败、配置检查失败却返回成功、异步错误无法传递和 CPU 线程数读取错误。新增回归测试与 CI,并补充中英文排障说明。真实微信上传不在本次测试范围内;依赖升级和版本发布另行处理。