feat(agents): improve workflow diagnostics and tool execution by waleedlatif1 · Pull Request #8290 · simstudioai/sim

waleedlatif1 · 2026-09-25T04:05:33Z

Summary

Add workflow/credential inspection, advisory lint, binding receipts, retry previews and compact CLI run summaries using existing platform primitives.
Preserve replay behavior, pin queued deployments, keep read/dry-run normalization non-mutating and retain tool-failure evidence.
Complete direct Function execution through the existing tool API with authorization, billing admission, selected-secret handling and owned output files.
Fix Slack bot-token/Block Kit behavior and bound history reads; preserve Stripe native values, capture amounts, subscription item IDs and pagination cursors.
Reuse canonical archive destinations and streaming downloads, remove sensitive parser logging and consolidate guidance in existing documentation.
Upgrade Next.js to stable 16.3.6, capture conflicting build assets, and load the two identified AWS credential providers natively through serverExternalPackages. Enforce the reviewed release-age exception against the exact Next pin in CI.

Type of Change

Bug fix
Feature

Testing

All applicable CI checks passed on 12f3407: Linux production build, lint/tests, both PostgreSQL provisioning paths, desktop E2E/package smoke, docs deployment, security and Helm.
Fresh CI tests: all 19 workspace tasks passed, including 34,646 app tests and 456 CLI tests; 20 inherited app skips remain.
All 26 workspace type-checks, 49 repository audits, lint, generated-document checks and migration gate passed.
Real Next standalone builds: 18 HTTP checks across 9 AWS credential scenarios matched before/after native loading. Missing-STS/Signin-file controls verified deployment coverage.
Frozen, ordinary and Turbo-pruned Linux-targeted Docker dependency installs passed. CI rejects using the temporary Next release-age waiver with another version.
Local full runs encountered existing timing/teardown flakiness and load-related timeouts. The timing failure reproduced independently on staging; the one-worker Node 24 rerun passed all 80 affected/focused tests without changing thresholds.
Prior real persistence/concurrency/CLI HTTP checks, 399,593 reference-scanner comparisons and guard-reversion controls remain valid; no workflow or credential behavior changed in the build fix.
Greptile 5/5 on current HEAD, all 24 review threads resolved, staging mergeable. Not merged.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-25T04:05:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 25, 2026 6:44pm UTC

cubic-dev-ai

1 issue found across 166 files

Confidence score: 4/5

In apps/sim/tools/slack/update_message.ts, an invocation with neither text nor blocks passes validation and reaches Slack without content; enforce that at least one is provided.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/tools/slack/update_message.ts">

<violation number="1" location="apps/sim/tools/slack/update_message.ts:53">
P3: `text` and `blocks` are now both optional and nothing enforces the description's claim that text is only omitted when blocks are provided. An invocation with neither field passes the `required` checks, reaches Slack's `chat.update` through `executeSlackUpdateMessage`, and fails with Slack's opaque `invalid_arguments` error instead of a clear local validation message. Raise a clear error in `operation.input` (or a validation step) when both are absent so the failure is caught before the provider call.</violation>
</file>

_{Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

greptile-apps · 2026-09-25T04:19:16Z

Confidence Score: 5/5

[Medium risk] Adds workflow diagnostics and tool execution APIs.

No new actionable issue or outstanding previous finding was identified in this review.

Summary

This PR adds workflow inspection and run diagnostics, direct Function tool execution, and integration and CLI improvements. The changes since the previous review add a Next.js 16.3.6 pin, a bounded release-age exception, AWS-provider build configuration, and build-failure artifact capture.

_{Reviews (13) · Last reviewed commit: "fix(build): load colliding AWS credentia..."}

waleedlatif1 · 2026-09-25T04:39:17Z

@greptile

waleedlatif1 · 2026-09-25T04:39:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T04:39:23Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 192 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-25T04:58:23Z

@greptile

waleedlatif1 · 2026-09-25T04:58:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T04:58:31Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 196 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-25T05:17:27Z

@greptile

waleedlatif1 · 2026-09-25T05:17:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T05:17:33Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 197 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-25T05:21:02Z

@greptile

waleedlatif1 · 2026-09-25T05:21:03Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T05:21:10Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 197 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

waleedlatif1 · 2026-09-25T05:50:54Z

@greptile

waleedlatif1 · 2026-09-25T05:50:55Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T05:51:01Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-25T16:54:58Z

@greptile

waleedlatif1 · 2026-09-25T16:55:00Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T16:55:06Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 203 files

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-25T18:27:04Z

@greptile

waleedlatif1 · 2026-09-25T18:27:05Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T18:27:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 212 files

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-25T18:42:44Z

@greptile

waleedlatif1 · 2026-09-25T18:42:45Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T18:42:51Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 214 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

waleedlatif1 marked this pull request as draft September 25, 2026 04:06

vercel Bot deployed to Preview September 25, 2026 04:07 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

waleedlatif1 marked this pull request as ready for review September 25, 2026 04:38

vercel Bot deployed to Preview September 25, 2026 04:40 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/executor/utils/run-from-block-preview.ts

Comment thread apps/sim/lib/workflows/application/replace-workflow-state.ts Outdated

Comment thread apps/sim/lib/logs/execution/trace-spans/span-factory.ts

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/docs/content/docs/cli/workflow-operations.mdx Outdated

vercel Bot temporarily deployed to Preview September 25, 2026 04:57 Inactive

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/application/replace-workflow-state.ts

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

vercel Bot deployed to Preview September 25, 2026 05:19 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

vercel Bot deployed to Preview September 25, 2026 05:22 View deployment

vercel Bot deployed to Preview September 25, 2026 16:56 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/lib/workflows/executor/enqueue-execution.integration.ts

waleedlatif1 added 12 commits September 25, 2026 11:15

feat(agents): improve workflow diagnostics and tool execution

368c0e9

fix(api): preserve workflow behavior and tighten diagnostics

8a6bd23

fix(workflows): preserve concurrent binding and tool failure evidence

6a16bfa

fix(agents): consolidate guidance and update authoring mocks

8c8b203

fix(docs): clarify run summary defaults and binary omission

70146ce

fix(integrations): preserve request values and bound Slack reads

29cb510

fix(workflows): avoid repeated reference overlap scans

7f66b15

fix(agents): complete direct Function execution and safe diagnostics

54172b7

fix(agents): retain legacy failures and continue output cleanup

2579549

fix(cli): prioritize failure evidence in run summaries

102ee20

improvement(tests): verify agent behavior at integration boundaries

8bacd63

fix(build): upgrade stable Next.js and capture collision diagnostics

a8f3ce7

waleedlatif1 force-pushed the codex/agent-interface-feedback branch from 8f98389 to a8f3ce7 Compare September 25, 2026 18:26

waleedlatif1 requested a review from a team as a code owner September 25, 2026 18:26

vercel Bot deployed to Preview September 25, 2026 18:28 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread .github/workflows/test-build.yml

Comment thread package.json

Comment thread bunfig.toml

Comment thread packages/testing/package.json

fix(build): load colliding AWS credential providers natively

12f3407

vercel Bot deployed to Preview September 25, 2026 18:44 View deployment

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Conversation

waleedlatif1 commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

Uh oh!

waleedlatif1 commented Sep 25, 2026

waleedlatif1 commented Sep 25, 2026 •

edited

Loading

vercel Bot commented Sep 25, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 25, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading