Publish the ABI check comment and labels via - #3276
Open
fujitatomoya wants to merge 1 commit into
Open
fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
Signed-off-by: Tomoya.Fujita <fujita.tomoya@triorb.co.jp>
fujitatomoya
commented
Sep 17, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
Author
There was a problem hiding this comment.
@ahcorde can you approve this?
note that, ABI compliance check is still in the test flight. i want see if it works for everyone including forked PR to put the compliance check comment and label after this PR is merged.
Comment on lines
+5
to
+11
| # This is a separate workflow because abi.yaml builds and diffs the pull | ||
| # request's own code. For pull requests from forks GitHub therefore runs it | ||
| # with a read-only token, whatever permissions it asks for, and it cannot | ||
| # write to the PR. workflow_run workflows instead run the workflow file from | ||
| # the default branch of this repository with a normal token; this one never | ||
| # checks out or executes anything from the pull request, it only downloads the | ||
| # report artifacts the abi run uploaded and posts what they say. |
Collaborator
Author
There was a problem hiding this comment.
this is exactly what this PR trying to solve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
shoudl close fujitatomoya/ros2-abi-action#13
Follow-up to #3262. Publish the ABI check's sticky comment and the
ABI compatible/ABI breaklabel from aworkflow_runworkflow so that pull requests from forks get them as well.Problem.
The
abiworkflow itself runs fine on fork pull requests (see #3268: all four libraries were diffed and reportedcompatible), but the comment and the label never appeared. Onpull_requestevents from a fork, GitHub gives the job a read-onlyGITHUB_TOKENregardless of thepermissions:block, so every write failed withResource not accessible by integration(visible as warnings in the diff job logs). Since nearly every rclcpp pull request comes from a fork, the label was effectively never applied.Fixes # (issue)
Is this user-facing behavior change?
Yes, forked PR can also comment about the abi-compliance result.
Did you use Generative AI?
Yes, Claude Fable 5.1
Additional Information