Repository navigation
Validate the canvas and let the catalogs return enumerators - #21
Merged
Merged
Conversation
Canvas raises an ArgumentError when the padding is negative or leaves no room for the sky, instead of drawing a sky with a negative radius. The catalogs raised a LocalJumpError when each was called without a block. They now return an enumerator, as Enumerable expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes found while auditing the project.
Canvasraised nothing when the padding left no room for the sky, so a padding of half the size or more drew a sky with a negative radius. It now raises anArgumentErrorfor a negative padding or one of at least half the size.eachwithout a block onCatalog::Stars,Catalog::ConstellationLinesorCatalog::ConstellationBoundariesraised aLocalJumpError. They now return an enumerator, asEnumerableexpects.