Repository navigation
Module/play start (PERSONALIZE PLAY START) - #947
jonathanwardle1992-beep wants to merge 11 commits into
Conversation
…inning. Co-authored-by: Cursor <cursoragent@cursor.com>
…ath. 0.1.9 hooks the 0x460d1aec==0 PLAY branch this unit uses (seqpause 0x4006188a, start 0x40061892). Same-unit card PS 0.1.9: with X, every PLAY starts from 1. Co-authored-by: Cursor <cursoragent@cursor.com>
0.1.9 stored 0/1 and treated any leftover SRAM as ticked, so YES had to run twice. Use MAGIC empty/X like TRACK MUTES. Co-authored-by: Cursor <cursoragent@cursor.com>
Photographs from 25 October 2026, converted to monochrome PNG. SYSTEM STATUS stamp on the unit reads PS 0.1.9. Co-authored-by: Cursor <cursoragent@cursor.com>
Populate README Usage, pin the native source fingerprint, use a POSIX modules/ gate path, and drop the leftover sdk/drafts/play-start copy now that the module folder has hardware LCD PNGs. Co-authored-by: Cursor <cursoragent@cursor.com>
Native source fingerprint now matches the folder, Gate() uses modules/play-start/verify.py, and Usage is populated so module-contract can pass. Co-authored-by: Cursor <cursoragent@cursor.com>
src/community/module-changelogs is checked against catalog-listed modules only, so an unlisted first release fails module-contract as Unknown changelog module. Co-authored-by: Cursor <cursoragent@cursor.com>
Skip byte clashes the configurator already refuses so PERSONALIZE growers can list without claiming they share a remix. Co-authored-by: Cursor <cursoragent@cursor.com>
repeat98
left a comment
There was a problem hiding this comment.
Thanks for this. Until you have a published module I review one pull request of yours at a time, and Track Mutes (#931) is first. Most of what I wrote there applies here too, so here's the list for Play Start to work through in the meantime:
- Please drop the edit to
scripts/module-compat.py(see #931, point 1). The clash with Mute Modes over the PERSONALIZE arrays and ANDY sites is the same design question as in #931 point 2. I'll answer it there. - Please keep it in
sdk/drafts/play-start/for now. #809 moved it there because it wasn't qualified yet, and it still needs the USB lifecycle (ADD_A_MODULE.md): a runtime package with the PERSONALIZE growth in the unit's own table, plus install, self-test, Keep/Undo, removal and reboot tested on the unit. - Hardware on the exact build.
evidence/hardware.mdsays 0.1.10 was packed but never flashed, so nothing has run the version being released yet. Please flash 0.1.10 (or put it on over USB) and record what you see. Your photos show the PS 0.1.9 stamp, butmedia/capture.jsoncredits them to the 0.1.10 image. Please retake them on 0.1.10, or label them as 0.1.9. - The red checks:
presentation/thumbnail.svgline 2 has a control byte (0x14) where the dash should be, so the preview JPEG comes out blank. A plain hyphen fixes it.resources.impact.dsp.rationale("No DSP code.",octamod.module.json:104) needs more than 20 characters.evidence/performance.jsonand the native comparison (npm run module:verify -- play-start --os <your 1.40C file>).
- Release notes. Players never had 0.1.0 to 0.1.9, so a single entry for the version you ship is enough. TESTING.md keeps the history.
module-build.jsonhas CRLF file sizes and hashes (see #931, point 8).- Whichever of Play Start and Track Mutes goes in second has to name the other in
conflictsand rebuild the packages, since both grow PERSONALIZE.
|
Thanks! This one waits behind Track Mutes (#931), since one module PR is reviewed at a time until your first is published. What I wrote there about USB and PERSONALIZE applies here too; the red check is the PERSONALIZE clash with Mute Modes. |
Keep the checkbox in the module instead of Mute Modes' battery word, drop the compatibility-script filter, and leave the PERSONALIZE tables until the shared row lands. Co-authored-by: Cursor <cursoragent@cursor.com>
Current main is 5f28c9a. Packages were not rebuilt. Track Mutes is not on main yet, so this conflict id stays unresolved until that module lands. PERSONALIZE growth still waits on repeat98#1023. Co-authored-by: jonathanwardle1992-beep <jonathanwardle1992-beep@users.noreply.github.com>
|
Hi, thanks for working through the list. The thumbnail, the DSP note, the single release note, and dropping both the Three things about the latest push:
No need to merge Generated by Claude Code |
Summary
PLAY START 0.1.11 answers the 26 October review that can be answered without a ColdFire rebuild or a unit.
ps_settingin this module. It no longer uses Mute Modes' battery word0x800000dc, and the ANDY length pokes are gone. It returns to empty after power-off until the base settings store exists.sdk/drafts/until a USB package exists. It stays listed, the same way TRACK MUTES stayed listed: a USB package cannot carry TableGrow, and an empty runtime declaration is refused.scripts/module-compat.pyfilter that hid declared conflicts.module:doctorstill fails onevidence/performance.json, the USB package, native comparison, and the PERSONALIZE table clash with Mute Modes.This pull request is PLAY START only. A push does not publish it and does not email followers.
Test plan
npm run modules:generatenpm run modules:pairs -- --writenpm run module:doctor -- play-start(performance, USB, native comparison and the Mute Modes table clash stay red)npm run module:verify -- play-start --os <1.40C>No check can prove these, so you vouch for them:
docs/module-guides/(andsequencing.mdif it acts in time), and TESTING.md lists what I did not test.Registered module authors can opt into automatic publication after reviewing all the evidence. An update that reaches firmware or hardware addresses the published version did not use goes to owner review instead:
Reviewer (the owner for a first release, the registered author for their own update):