Repository navigation
Fix: the PR triage bot reads only the newest run of each check - #1127
Merged
Merged
Conversation
A cancelled or failed earlier workflow run sits in its own check suite beside the green rerun, and filter=latest only dedupes within one suite, so the bot would have labelled #1088 needs-work. Keep the newest run per check name (started last, then the higher id) before deciding red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/pr-triage.mjscalled a pull request red if any check run on its head commit had failed. Each workflow rerun is a new check suite, andfilter=latestonly dedupes within one suite, so a failed or cancelled earlier run sitting beside its green rerun still counted. Improvement: prepare USB-only Sample Locks packaging and hardware evidence #1088 would have been labelledneeds-workfor the failedmodule-pr-okfrom a cancelled run, even though the rerun is green.newestRuns()keeps one run per check name before the red decision: the run that started last (a run with no start time yet counts as newest), with the higher id breaking ties. The script reads no commit statuses, so nothing else needed the same treatment. The workflow stays disabled, and labels andpr-triage.ymlare unchanged. Changelog:changelog/2026-11-01-pr-triage-newest-run.md.scripts/pr-triage.test.mjs(green rerun replaces a failure, a tie goes to the higher id, a run not started yet counts as newest, a newer failure stays red). I ranPR_TRIAGE_DRY_RUN=1 node scripts/pr-triage.mjsagainst the live repository before and after. Before: needs-work on Improvement: prepare USB-only Sample Locks packaging and hardware evidence #1088, Temp Save 0.1.0-experimental: FUNC + YES temp-saves the pattern and its Part, FUNC + NO reloads (Octatrack) #1035, Mute Modes 0.2.2-experimental: SHADOW out of the stock timestretch task's SRAM (owner review) #1007, Module/play start (PERSONALIZE PLAY START) #947 (plus one-at-a-time), Module/track mutes (MPC style) #931 and FM Synth 0.1.5: scale quantizer on MIDI tracks (the author's 2.13 quantizer) #555. After: the same list without Improvement: prepare USB-only Sample Locks packaging and hardware evidence #1088. The other five have failing checks on their newest runs (module-contract,module-pr-ok,module-paths-windows).npm run pr:ready: Ready.🤖 Generated with Claude Code