Repository navigation
Fix: FM Synth's voices pass the Octatrack base's frame guard and CPU budget - #1483
Merged
Merged
Conversation
…budget The base checks every renderer at the frame builder's two calls, so a renderer a module wrote into the slots itself is refused and guarded like a machine's own. Co-Authored-By: Claude <noreply@anthropic.com>
repeat98
enabled auto-merge
November 12, 2026 18:17
This was referenced Nov 13, 2026
ex1010
pushed a commit
to ex1010/modwerk
that referenced
this pull request
Nov 13, 2026
Upstream's repeat98#1483 rebuilt the base; this regenerates it with the engine price change on top: Analog BD's recipe recaptured (identical copies and fills), base and base-bound packages rebuilt, Sidechain 0.2.1's held entry pointed at the new base (test_base_bound_trust caught it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong or hard: FM Synth 0.1.2 puts its own renderer straight into the tracks' renderer slots (a detour at the frame builder's slot copy
0x4000d514, plus the STATIC table entry). The base's FLEX render hook never ran for an FM Synth track, so neither the frame guard nor the CPU budget (Improvement: a CPU budget admits Octatrack machines before they play #1482) counted, shed or silenced its voices. Three FM Synth tracks beside a busy eight-track pattern froze the unit on PLAY.What this changes: The base checks every renderer at the frame builder's two calls (
0x4000d43e,0x4000d52c, two more frame-guard sites). Stock's renderers and the base's own go straight through. A renderer a module put there itself goes throughmw_foreign_render:catalogue_overlapspasses). New beta based377cece; the five base-bound packages are relinked to it, their code unchanged.How I checked it:
npm run pr:readysays Ready on main1f5dcae41; the registry host test covers the guard, the stock fallback and the CPU refusal on the new path. On the owner's MKII, a RAM-booted dev twin of this branch (c44b117b), OS 1.40C, FM Synth 0.1.2 as a trial, one short run each:cpushows the FM Synth track (7.6 % of a frame at its longest); on the twin before, 0.0.dfbf58d6).d377ceceitself was not run on a unit, only its dev twin; the trial counted one loader refusal on this twin that I did not trace (FM Synth installed and ran).What the guides lacked or got wrong, and where I fixed it: nothing said that a module-written renderer escapes the guard;
docs/MODULE_PERFORMANCE.mdnow says the base checks every renderer at the two calls.Related to #1473.
🤖 Generated with Claude Code