Repository navigation
Conversation
The CPU budget prices machine renders only. A pick is now also refused while the CPU meter stands at 85 % or more over its last four seconds, with the same box showing the measured load. Host tests cover the registry and the box; seen on an MKII on a development twin. The base is not regenerated. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The loader's selection guard asks status.c before stock writes an FX pick: a module's effect on a unit at 85 % CPU or more is refused with the CPU FULL box on its slot. Stock effects and NONE always pass. selection.c links after the write-lease entries, which do not move. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Owner
Author
|
Closed into #1502: all changes that need a new Octatrack base go out as one base update. This branch is merged there with its commits, and its description and test notes are carried over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
926a4fdf, 20 modules) the CPU meter stood at 76 % stopped and 85 to 95 % playing, and nothing refused anything.mw_cpu_hot,modwerk_status_cpu_recent). The box shows the measured load and "UNIT IS BUSY". The same machine on its own track, stock's machines and effects, and NONE are never refused, so a busy unit can always be made lighter. The refusal counts in the diagnostics log as a CPU refusal.docs/MODULE_PERFORMANCE.mdsays where the 85 % line comes from, and that the panel is to be judged by the CPU meter, not by the frame guard's share.selection.c, throughbuild_core.py's refusal edits), before stock writes the pick, and asksmodwerk_status_effect_busy.selection.clinks after the write-lease entries: on twins ofmainand of this branchmodwerk_controller_write_begin/endare at the same addresses and the first moved symbol is past them, so Analog BD's reviewed recipe should hold.dsp.candmanager.care untouched.octatrack-base.test.tsfails on the stale base until its turn in the base queue.test_machine_registry.c(refused at the line, passes one under it, own track and stock never refused, counted, no price box) andtest_status.c(the meter's mean, the box's fields; a module effect refused on its slot and counted, a stock effect, NONE and a load under the line pass).npm run checkpassed except the stale-base test above, run before the effect commit and not again after it.npm run sdk:checkfails two tests that fail the same way on untouchedmainon this computer (test_dsp_packages_rebuild_from_source: KeyError 'modulation';test_real_units_relocate_alike…: 1004 != 1009).0dbd0ee2of this branch, 15 modules, playing at 126 BPM): at 86 % CPU, picking FM Synth on T2 in SRC SETUP showed "CPU FULL / T2 SRC / FM SYNTH / CPU 86% / UNIT IS BUSY" and T2 kept its machine. On twin865bcc10(this branch withmainmerged, Fix: an installed Sidechain keeps its key bus memory free from the start, so picks are not refused NO ROOM after a restart #1492 in): at 85 % picking Euclid on T2 FX1 showed "CPU FULL / T2 FX1 / EUCLID / CPU 85% / UNIT IS BUSY" and the slot stayed NONE; at 88 % FILTER and NONE on the same slot went through; stopped, at 63 %, Euclid went through. Not tried on the unit: a pick just under the line, the box over other pages, a waiting (queued) pick, a Part change or paste that brings module effects in (those are not refused by design).diag.hsays a UI tick comes every 2.7 frames; on the unit it is 60 a second (300 in 5 s), which first led me to a wrong conclusion. Not corrected here, sincediag.his a base source; it belongs with the base rebuild.docs/MODULE_PERFORMANCE.mdnow says to judge the panel by the CPU meter.Draft until: its turn in the base queue (rebuild after #1494 and #1487).
🤖 Generated with Claude Code