Repository navigation
Conversation
…o the battery table. The indexer is unchanged. Listing needs the screen claim, the 2048-byte clear, and one byte per bank, on-screen pattern and track. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Thanks, the screen claim, the 2 KB and the index (bank, pattern on screen and track) all match the code now. Two things about the battery table before it's listed:
The red check isn't yours: a timing test in the site's account code ran just over its 5 s limit, and this pull request only touches the draft's folder. The two points above can come here or in your next Micro Timing pull request, whichever suits you. Generated by Claude Code |
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This answers the pre-listing notes on #1154 (comment). The draft stays
0.1.0-experimental. The indexer is unchanged: the screen claim, the memory rationale and the player text now match the code. Author and reviewer boxes stay unticked. This does not publish the module and does not email followers.compatibility.uiClaimsis["screen:TRACK TRIG EDIT"]. The module takes no key of its own.0x4d54494dat0x100f8ffcand the table at0x100f9000are named in the source (MT_MAGIC,MT_TABLE) and in the manifest. There is no declaration slot for a draft's battery words (Claims.sramis on-chip SRAM), so the rationale says that instead of a new scheme. The addresses are not moved. No trap document names these bytes as taken. Play Modes ends at0x100f8f06and the diagnostic log starts at0x100fc000.mt_ensurestill clears0x200longs, 2048 bytes from0x100f9000through0x100f97ff, plus the 4-byte magic. The largest index the bank, on-screen pattern and track math can form is 2047, so the clear is the size the indexer uses.0x100b14d0, not the sequencer pattern at0x800065be.What the guides lacked: a draft has nowhere to declare battery words so the gate can see them. Nothing in the guides was edited here.
Test plan
npm run module:doctor -- --draft micro-timingDoctor, with Python UTF-8 as CI uses it: ui claims
screen:TRACK TRIG EDITand cross-compatibility are green. Still red for the known draft reasons: catalog entry, qualification (modules:check), packages, USB package, native comparison, pair table, and package fingerprint. Those reds are the listing gaps, not this claim, rationale or README. A Windows code-page run also reports alofi2.asmdecode error inside the composition check; that file is not part of this draft, and the UTF-8 run does not.No check can prove these, so you vouch for them:
docs/module-guides/(andsequencing.mdif it acts in time), and TESTING.md lists what I did not test.Registered module authors can opt into automatic publication after reviewing all the evidence. An update that reaches firmware or hardware addresses the published version did not use goes to owner review instead:
Reviewer (the owner for a first release, the registered author for their own update):
Related to #1154