Repository navigation
Improvement: a ledger of the Octatrack's battery RAM, checked - #1322
Merged
Merged
Conversation
sdk/machines/octatrack/battery-ram.json names who holds each range of the battery RAM stock leaves free. sdk/tests/test_battery_ram.py refuses overlapping ranges and any address the base, a module or a draft names there outside its owner's range (comments skipped; test, probe and emulator files read freely). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Battery RAM that stock leaves free (
0x100f859c-0x100fff00) keeps its contents through a power cycle. The base, Play Modes and drafts all keep data there, but nothing recorded who holds which range. Today the new module store (#1320) first took a range that overlaps the Micro Timing draft's table (0x100f8ffc-0x100f97ff, #1262), and no check noticed. The draft's own manifest says "there is no declaration slot for a draft's battery words".sdk/machines/octatrack/battery-ram.jsonlists each range, its owner and what it holds:PMNV;sdk/tests/test_battery_ram.py(insdk:check) refuses:It reads C, C++ and ColdFire assembly with comments removed. Test, probe and emulator files may name any range, because they read rather than keep. Vendored
upstream/trees are skipped.The module guides' README ("A module owns what it saves") names the file.
When #1320 rebases onto this, it adds its range (
0x100f9800-0x100fc000, ownerbase), and the check refuses it until then.How I checked
main.usuffix, assembly, test files and the base. It already caught one bug of mine: a\bthat missed suffixed literals.store.c:0x100f8f08-0x100fbf10) would be refused as overlapping Micro Timing.npm run pr:ready: Ready. The first run failed insdk/runtime/upload/tests/run_host.shon an acknowledgement timeout while another build loaded the machine. That test passes alone, and the rerun was Ready.Guides
The guides had no place to say which battery RAM a module may use. The ledger is that place now, and the README line points to it.
🤖 Generated with Claude Code