-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Finalize v0.16.0 #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Finalize v0.16.0 #2863
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
249443b
rough merge of v0.15.3 and 0.16.0 whatsnews
kandersolar 19d6105
fix backticks
kandersolar d8112a4
miscellaneous cleanup
kandersolar 9eb4600
push out some deprecation removals
kandersolar 8f842d5
a bit more cleanup
kandersolar 632a714
add missing contributors
kandersolar cb98324
final tweaks
kandersolar 59f214d
Increment release date
kandersolar 37f3e0a
increment release date
kandersolar 44e06ba
changes from review
kandersolar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| .. py:module:: pvlib.irradiance | ||
|
|
||
| .. currentmodule:: pvlib | ||
|
|
||
| Irradiance | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke the entry at https://pvlib-python.readthedocs.io/en/latest/reference/bifacial.html (bottom). Add
.. currentmodule:: pvlibjust below or disregard that line. Just in case, settingcurrentmoduleorpy:module, indicates the namespace of the functions/entries relative to that namespace that will be documented inautosummaries. Therefore, the first entry in the followingautosummary"bifacial.utils.vf_row_sky_2d" would now point topvlib.bifacial.utils.bifacial.utils.vf_row_sky_2d.There's a slight difference on
currentmoduleandpy:moduleregarding defaults and global TOC IIRC: https://www.sphinx-doc.org/en/master/usage/domains/python.htmlI'm not available for fast fixes this weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so none of the VF functions are included now. Ugh, I wish I had actually thought about what I was adding. Or checked the build log. Or waited a few more minutes so you had time to point out the error. 🤦
Anyway thanks @echedey-ls. I guess I will make a v0.16.1 release!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem from my side.
That's on me, I was doomscrolling instagram instead of GitHub :(