Finalize v0.16.0 - #2863
Finalize v0.16.0#2863
Conversation
echedey-ls
left a comment
echedey-ls
left a comment
There was a problem hiding this comment.
Sorry for the noise. Feel free to disregard whatever comments you want.
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
|
|
||
| bifacial.power_mismatch_deline | ||
|
|
||
| .. py:module:: pvlib.bifacial.utils |
There was a problem hiding this comment.
This broke the entry at https://pvlib-python.readthedocs.io/en/latest/reference/bifacial.html (bottom). Add .. currentmodule:: pvlib just below or disregard that line. Just in case, setting currentmodule or py:module, indicates the namespace of the functions/entries relative to that namespace that will be documented in autosummaries. Therefore, the first entry in the following autosummary "bifacial.utils.vf_row_sky_2d" would now point to pvlib.bifacial.utils.bifacial.utils.vf_row_sky_2d.
There's a slight difference on currentmodule and py:module regarding defaults and global TOC IIRC: https://www.sphinx-doc.org/en/master/usage/domains/python.html
I'm not available for fast fixes this weekend.
There was a problem hiding this comment.
Right, so none of the VF functions are included now. Ugh, I wish I had actually thought about what I was adding. Or checked the build log. Or waited a few more minutes so you had time to point out the error. 🤦
Anyway thanks @echedey-ls. I guess I will make a v0.16.1 release!
There was a problem hiding this comment.
No problem from my side.
waited a few more minutes so you had time to point out the error
That's on me, I was doomscrolling instagram instead of GitHub :(
* fix sphinx issue see #2863 (comment) Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> * PR number --------- Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
2 participants
[ ] I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib licenseno AI[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.