Remove the decision and actionhook packages - #55
Merged
Merged
Conversation
Both existed for the hosted control plane (signed intents, decisions, approvals, receipts, and the before/after action boundary), which was retired on 2026-10-01. The daemon stopped using them in v1.14.0, and their last importers, dataexchange, eventstream and handshake, drop them in their own changes. No other package in this module imports either one; go.mod and go.sum are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 1, 2026
TeoSlayer
marked this pull request as ready for review
October 1, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
decision(39 files) andactionhook(2 files). Both existed for the hosted control plane, which was retired on 2026-10-01; the daemon stopped using them in v1.14.0.Why this is safe to merge now
A
commonversion without these packages only breaks a module that moves to it while still building a plugin version that imports them. Nothing on any dependent'smaindoes any more:dataexchangev0.3.0,eventstreamv0.3.0 andhandshakev0.3.0 no longer import either package.pilotprotocolmain pins those three (pilotprotocol#503).libpilot,runtimeandwebhookwere the last ones on handshake v0.2.8. They moved to v0.3.0 through the cascade (libpilot#58, runtime#45, webhook#40).An earlier version of this description said a new daemon release was needed first. It is not: already released daemon versions pin
commonv0.5.15, which keeps the packages, so they build as before.Checked
In this module, with
GOWORK=off:go build ./...,go vet ./...andgo test ./...pass, no remaining package imports either one, andgo mod tidyleavesgo.mod/go.sumunchanged.Every dependent's
main, moved to this commit the way the cascade does it (go get common@bff1207,go mod tidy), thengo build ./...,go vet ./...,go test ./... -short:TestManualSnapshotTriggerneeds port 18080, which another program holds on the machine that ran thisNot affected unless someone bumps them by hand:
pilot-agents/responder,app-store/integrationandexamples/gopin oldcommonversions and are outside the cascade.After merge
Tag
v0.6.0(a minor bump, because exported packages are removed). A module that upgradescommonto v0.6.0 must also be on dataexchange, eventstream and handshake v0.3.0 or later.🤖 Generated with Claude Code