deps: dataexchange v0.3.0, eventstream v0.3.0, handshake v0.3.0 - #503
Merged
Merged
Conversation
The three plugins dropped the governed-envelope and action-hook code that the retired hosted control plane used. The daemon stopped configuring it in v1.14.0, so nothing changes for ordinary traffic; a data-exchange frame of the retired types 8 or 9 is now refused as an unsupported type. With this, nothing in the daemon's dependency graph imports common/decision or common/actionhook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the daemon to the plugin releases that no longer contain the governed-envelope and action-hook code the retired hosted control plane used (dataexchange#46, eventstream#41, handshake#44).
The daemon stopped configuring any of it in v1.14.0, so this is dead-code removal. The one observable change: a data-exchange frame of the retired types 8 or 9 is now refused as
unsupported frame type, the same as any unknown type; before, the reply said no verifier was configured.After this, nothing in the daemon's dependency graph imports
common/decisionorcommon/actionhook, which unblocks removing those packages fromcommon(pilot-protocol/common#55).Verification
GOWORK=off:go build ./...,go vet ./cmd/... ./pkg/...andgo test ./cmd/...pass.go test ./cmd/... ./internal/... ./pkg/...passed, andgo test -parallel 4 ./tests/had two failures,TestManualSnapshotTrigger(port 18080 is taken on the test machine) andTestEphemeralPortLeakOnSendDatagramError, which passes 3/3 on its own both with and without this change.send-message(ACK and inbox) andsend-file(identical bytes).🤖 Generated with Claude Code