fix(tests): expect forward-slash filename from spatialgeometry >= 1.4.1 - #702
Merged
Merged
Conversation
Mesh.to_dict()["filename"] now normalizes to forward slashes (SG's jhavl/swift#152 fix for Swift's JS mesh loader on Windows paths), which broke test_mesh_filename's native-separator comparison on every Windows CI job (confirmed on both #698 and #699, unrelated to either PR's own changes) since SG 1.4.1 released 2026-09-21. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
petercorke
force-pushed
the
fix/test-mesh-filename-windows-sep
branch
from
September 27, 2026 11:46
7ab5ab1 to
097184c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 143 143
Lines 14093 14093
=====================================
Misses 14093 14093 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
petercorke
added a commit
that referenced
this pull request
Sep 27, 2026
…703) spatialgeometry 1.4.1 (jhavl/spatialgeometry#49) now builds a genuine py3-none-any wheel for Pyodide and publishes it to PyPI directly, closing the gap this step's own comment anticipated (jhavl/spatialgeometry#46). piplite/micropip already falls back to PyPI for any package not staged in the local docs/lite/pypi index, so no special-casing is needed -- confirmed with `pip download --platform any --only-binary=:all: spatialgeometry==1.4.1` resolving the py3-none-any wheel straight from PyPI. The step had also gone from stale to broken: it targeted a `cp312*pyodide*wasm32*` GitHub Release asset that no longer exists for 1.4.1 (superseded by the PyPI wheel above), which was failing the docs-build job on every PR once the Windows test-matrix fix (test_mesh_filename, #702) let it actually run. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_collision.py::TestToDict::test_mesh_filenameassertsMesh.to_dict()["filename"] == str(f)(native path separators). SG 1.4.1(released 2026-09-21, jhavl/swift#152) changed
to_dict()["filename"]toalways normalize to forward slashes, for Swift's JS mesh loader on Windows
paths. Since
pyproject.tomlpinsspatialgeometry>=1.4.0(unbounded), anyCI run from that date onward picks up 1.4.1 and fails this assertion on
every Windows job — confirmed independently on #698 and #699, neither of
which touch this code path.
Fix: compare against
f.as_posix()instead ofstr(f), matching SG'sdocumented normalization.
Related
Unblocks Windows CI on #698 and #699 (and any other open/future PR) once
merged and those branches are rebased/re-run.
Checklist
🤖 Generated with Claude Code