fix(docs): drop the obsolete cross-repo spatialgeometry wheel fetch - #703
Merged
Merged
Conversation
spatialgeometry 1.4.1 (jhavl/spatialgeometry#49) now builds a genuine py3-none-any wheel for Pyodide and publishes it to PyPI directly, closing the gap this step's own comment anticipated (jhavl/spatialgeometry#46). piplite/micropip already falls back to PyPI for any package not staged in the local docs/lite/pypi index, so no special-casing is needed -- confirmed with `pip download --platform any --only-binary=:all: spatialgeometry==1.4.1` resolving the py3-none-any wheel straight from PyPI. The step had also gone from stale to broken: it targeted a `cp312*pyodide*wasm32*` GitHub Release asset that no longer exists for 1.4.1 (superseded by the PyPI wheel above), which was failing the docs-build job on every PR once the Windows test-matrix fix (test_mesh_filename, #702) let it actually run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #703 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 143
Lines ? 14093
Branches ? 0
======================================
Hits ? 0
Misses ? 14093
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs.yml's "Fetch spatialgeometry pyodide wheel for JupyterLite" step
downloaded a
cp312*pyodide*wasm32*-tagged wheel from spatialgeometry'sGitHub Release, since SG didn't publish that wheel to PyPI. That release
asset no longer exists as of spatialgeometry 1.4.1 — SG's
PR #49 switched to
building a genuine
py3-none-anywheel and publishing it to PyPIdirectly, closing the gap issue #46
(filed against SG) asked for. This is exactly what this step's own
comment anticipated ("once SG applies the same fix RTB just did, this
step ... can go away in favour of a plain
pip download/PyPI dependencyresolution").
Confirmed the PyPI wheel resolves directly:
piplite/micropipalready falls back to PyPI for any package notstaged in the local
docs/lite/pypiindex (this is how every otherdependency — numpy, scipy, spatialmath-python, etc. — already resolves),
so no replacement step is needed; deleting it is the fix.
This unblocks
docs-build, which was failing on every PR once theWindows test-matrix fix (#702) let it actually run — the step's target
release asset silently stopped existing when SG shipped 1.4.1.
Checklist
🤖 Generated with Claude Code