fix(trajectory): honour non-zero time origins in scalar profiles - #698
Merged
petercorke merged 2 commits intoSep 27, 2026
Merged
Conversation
Owner
|
Thanks for finding this. I think the same issue will exist for |
3 tasks done
petercorke
added a commit
that referenced
this pull request
Sep 27, 2026
Mesh.to_dict()["filename"] now normalizes to forward slashes (SG's jhavl/swift#152 fix for Swift's JS mesh loader on Windows paths), which broke test_mesh_filename's native-separator comparison on every Windows CI job (confirmed on both #698 and #699, unrelated to either PR's own changes) since SG 1.4.1 released 2026-09-21. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
petercorke
added a commit
that referenced
this pull request
Sep 27, 2026
….1 (#702) Mesh.to_dict()["filename"] now normalizes to forward slashes (SG's jhavl/swift#152 fix for Swift's JS mesh loader on Windows paths), which broke test_mesh_filename's native-separator comparison on every Windows CI job (confirmed on both #698 and #699, unrelated to either PR's own changes) since SG 1.4.1 released 2026-09-21. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Added tests for trajectory plotting and time origin handling.
petercorke
force-pushed
the
fix/scalar-trajectory-time-origin
branch
from
September 27, 2026 14:58
337d3da to
a6e3932
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 143 143
Lines 14093 14097 +4
=====================================
- Misses 14093 14097 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Thanks supporting the Robotics Toolbox. Your PR is now merged. As per the previous comment, the issue might apply to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quinticandtrapezoidaldocument scaling by the first and last times, but treat the last timestamp as the duration. Forquintic(0, 1, np.linspace(5, 7, 5)), the first position is about 0.855 instead of 0; valid trapezoidal velocities can also be rejected.Use elapsed time for scalar profiles while retaining the supplied timestamps. Apply the same time origin to trapezoidal plot phases and show the supplied time range on each subplot. Keep
ctrajsampling its existing zero-origin profile directly so unordered samples retain their behaviour. Add regressions for positive/negative origins, endpoint velocities, multi-axis trajectories, plot ranges and phase samples.Validation on Windows/Python 3.12:
git diff --checkpass. Ruff lint has the same 14 existing diagnostics as the base revision.Prepared with Codex; the validation above was run locally.
Related issue
None.
Checklist
type: description)pytest)