Skip to content

Propagate keepalive callback exceptions - #17

Open
kristjanvalur wants to merge 6 commits into
perforce:masterfrom
kristjanvalur:keepalive-exception-propagation
Open

kristjanvalur wants to merge 6 commits into
perforce:masterfrom
kristjanvalur:keepalive-exception-propagation

Conversation

@kristjanvalur

@kristjanvalur kristjanvalur commented Nov 14, 2026 •

Copy link
Copy Markdown

Summary

  • Propagate Python keepalive errors and release callback results.
  • Manage callback ownership and honor the client user cancellation flag. Internal code signals intent to break using the alive flag on the PythonClientUser instance.
  • Use pending-exception helpers and test KeyboardInterrupt propagation.
  • Simplify return value check, use Python truthiness instead of explicit integer tests.

Validation

  • Built the extension and ran testSetbreak and testCallbackExceptions.

@kristjanvalur
kristjanvalur marked this pull request as ready for review November 14, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant