Skip to content

Propagate progress callback exceptions - #21

Open
kristjanvalur wants to merge 14 commits into
perforce:masterfrom
kristjanvalur:progress_exceptions
Open

kristjanvalur wants to merge 14 commits into
perforce:masterfrom
kristjanvalur:progress_exceptions

Conversation

@kristjanvalur

Copy link
Copy Markdown

Dependency and review scope

This PR is based on #17 (keepalive callback exception handling). Because GitHub does not support native cross-fork stacked PRs, its base is upstream master, so the diff currently includes all changes from #17 as well as the progress changes. Please review #17 first.

For the progress-only diff while #17 is open, see the comparison against the keepalive branch or the fork-local draft. Once #17 is merged, the branch may need updating depending on the merge method.

Progress changes

  • Propagate progress callback failures and cancel ongoing operations.
  • Preserve pending exceptions across interrupted transfers and reconnects.
  • Pass long progress totals using the correct Python argument format.
  • Test progress exceptions, reconnects and keepalive interactions.

Validation

  • Built the extension and ran testProgress, testSetbreak and testCallbackExceptions.
  • Previously checked long boundaries with a native harness.

@kristjanvalur
kristjanvalur marked this pull request as ready for review November 14, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant