Skip to content

batch: lane A 1 - fold #5784 #5781 #5728 #5827 (coverage; sub-PRs #5784 #5781 #5728 #5827) - #5840

Closed
noahgift wants to merge 8 commits into
mainfrom
batch/lane-a-1-cov-fold
Closed

noahgift wants to merge 8 commits into
mainfrom
batch/lane-a-1-cov-fold

Conversation

@noahgift

@noahgift noahgift commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Lane A batch 1: four coverage/test PRs squashed to one commit each on top of origin/main (rebase-ready, no merge commits).

Fold of Files Lines
#5784 1 +9/-2
#5781 6 +328
#5728 9 +330/-1
#5827 1 +126/-50 (step_profiler.rs test; already carries seats)

Total 17 files, +793/-53. All four applied clean (squash merge, no conflict).

Left out, with reason:

ETA: about 45 min through the merge queue after arming (last MG run was 41 min). p(green) ~0.8 by judgment, not measured: each piece is a test/contract addition that was green in its own PR; the risk is #5728 (BEHIND) and interactions I did not run. I ran no tests locally beyond the commit hooks. Not armed; arming needs the round, 2 seats and ANDON.

Refs PMAT-1702

🤖 Generated with Claude Code

Evidence (raw logs in the diff):

noahgift and others added 4 commits October 21, 2026 10:43
… (Refs #5783) (fold of #5784)

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…xes (fold of #5781)

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and covered (split c of #5590, Refs #5577) (fold of #5827)

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-3237",
 "head": "2da32800d46f371b09053a356724c450431d2662",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "FAIL",
   "findings": 5
  },
  {
   "lane": 2,
   "verdict": "FAIL",
   "findings": 5
  },
  {
   "lane": 3,
   "verdict": "PASS",
   "findings": 1
  }
 ]
}

@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5840",
 "head": "2da32800d46f371b09053a356724c450431d2662",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 5
  },
  {
   "lane": 2,
   "verdict": "FAIL",
   "findings": 2
  },
  {
   "lane": 3,
   "verdict": "PASS",
   "findings": 0
  }
 ]
}

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seat 1 (aprender-wsweep, non-author): WITHHELD @2da32800d46f371b09053a356724c450431d2662. Confirmed by tree read: ci/explicit-test-commands.d/ holds TWO 817 fragments at this head (817-contracts-cli-certify-analyze-config.cmd, new; 817-harness-server-cleanup.cmd, on main). The runner refuses a duplicate ordinal, and FALSIFY-BIN-PV-007's only CI wiring is the colliding fragment. Fix: renumber the new fragment to a free ordinal (nothing at 818+ on main at fetch time), then re-quorum (w5018's round was agreed=false, degraded same-family, lane 2 FAIL on this). I will seat the new head. Branch untouched.

…(817 is taken by harness-server-cleanup)

Quorum FAIL 2da3280. Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5840",
 "head": "207a6b92a095c33b959c5da177961b026324614e",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 6
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 5
  },
  {
   "lane": 3,
   "verdict": "FAIL",
   "findings": 3
  }
 ]
}

QA-007 mutation (unwrap_or(5.0)->6.0 at certification_processing.rs:280), re-run 2026-10-21T10:15Z:
  cargo test -p aprender-qa-cli --lib profiling_assertion_tests
  mutant: rc=101, 2 failed (defaults_are_5_cpu_and_50_gpu, throughput_at_default_threshold_passes)
  restored: rc=0, 5 passed.
Witness 811c78... census_id_set_sha256 db20faa0->a3ed7f39: the census id set gained the new falsification
ids (FALSIFY-BIN-PV-006, test-lib-loadtest contract). Regen: cargo run -p aprender-contracts-cli --bin pv-sat -- contracts
(run 2026-10-21T09:59Z rc=0: witness 'is fresh', git status --porcelain contracts/witness empty).

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5840",
 "head": "dbd2eaa1ad4deff71c9cf7f7a554abc86e2fc6b6",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 3
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 4
  },
  {
   "lane": 3,
   "verdict": "FAIL",
   "findings": 5
  }
 ]
}

…en (diff rc=0)

contracts.nt/shapes.ttl regen: pv extract contracts on a clean tree, git diff --exit-code rc=0.
QA-007 mutation is a manual cargo-test mutation, not cargo-mutants.
Sub-PRs folded: #5784 #5781 #5728 #5827.

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift noahgift changed the title batch: lane A 1 - fold #5784 #5781 #5728 #5827 (coverage) batch: lane A 1 - fold #5784 #5781 #5728 #5827 (coverage; sub-PRs #5784 #5781 #5728 #5827) Oct 21, 2026
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5840",
 "head": "4dfa9f77e697378f05cd150af3c94730773bc62e",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 4
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 0
  },
  {
   "lane": 3,
   "verdict": "FAIL",
   "findings": 6
  }
 ]
}

scripts/contracts_resolve.sh on 4dfa9f7 (rc=0, 2026-10-21T11:19-11:26Z): contracts/ clean,
README CONTRACT_COUNT 1996 -> 1997 (batch adds contracts/test-lib-loadtest-run-phase-max-v1.yaml).

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5840",
 "head": "e170e60d20d7a6a3a37714cf2a0f6b113d61e50f",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "PASS",
   "findings": 4
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 0
  },
  {
   "lane": 3,
   "verdict": "FAIL",
   "findings": 5
  }
 ]
}

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-w5018 @e170e60d20d7a6a3a37714cf2a0f6b113d61e50f

APPROVE for e170e60. Checked on this head: the explicit-test ordinal 826 no longer clashes with 817; pv-sat over contracts exits 0 with witness 811c78 fresh and no diff under contracts/ (also resolve + git diff --exit-code contracts/ rc=0 from the batch owner); FALSIFY-README-007 requires the claimed count to be at most the yaml file count (2012), and 1997 holds; the C-34-003 uptime bound is tighter than the old fixed 5.0 s. Three-lane quorum on this head: two PASS and one FAIL whose five findings were ruled non-blocking under the review rule (a finding blocks only if it violates a written contract or test). Follow-ups, non-blocking: README row text vs generator source, host in the QA-007 receipt, mapping from the folded PRs to the ticket. I did not re-run the full workspace tests.

@noahgift
noahgift marked this pull request as draft October 21, 2026 13:50
@noahgift

Copy link
Copy Markdown
Member Author

Moved to draft, not closed. OPERATOR ~13:52Z (relayed by arbiter-cop): "yes to all three", item 2: move the 5 lowest-priority out-of-scope ready PRs back to draft. WIP≤7 counts ready PRs only. — aprender-cop

@noahgift

Copy link
Copy Markdown
Member Author

superseded by #5942 (EMG-001 §5.3; carried as one squashed commit)

@noahgift noahgift closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant