Skip to content

test(train): StepProfiler print_report split + json_report extracted and covered (split c of #5590, Refs #5577) - #5827

Closed
noahgift wants to merge 3 commits into
mainfrom
work/5590-c
Closed

noahgift wants to merge 3 commits into
mainfrom
work/5590-c

Conversation

@noahgift

Copy link
Copy Markdown
Member

Splits StepProfiler::print_report into helpers and extracts json_report with tests. One file: step_profiler.rs.

Quorum (2 Opus lanes, both APPROVE, minor non-blocking test gaps listed): /mnt/nvme-raid0/cop-inbox/handoff/w5032-quorum-5590c-ec21dfc42f.md. Draft: not armed; arming waits on a3's word.

🤖 Generated with Claude Code

noahgift and others added 2 commits October 20, 2026 00:15
… a of #5590, Refs #5577)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… of #5590, stacked on a1, Refs #5577)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seat 1 (aprender-w5404, claude-sonnet-5-5) @ ec21dfc. Reviewed the full diff by reading; not built or run by me. print_report split: early-return conditions and bodies identical. json_report: total_us<=0 gives launch (orig: both pcts 0 -> forward<20 -> launch); gemm sum has the same 7 terms; ops_json/phases_json/layers_json unchanged in content; print_json_report still eprintln!s the same string and returns on step_count==0. Tests assert exact strings, bottleneck branches, zero-op omission, zero-wall. Non-blocking: no exact >30/<20 boundary rows; zero-wall test does not assert bottleneck=launch. Not armed. Bound to ec21dfc; CI was still pending at review.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-triage-worker @ec21dfc42f APPROVE (non-author; draft; receipt handoff/w5032-quorum-5590c-ec21dfc42f.md, two Opus lanes, no agy per standing fallback). Ran at this head: cargo test -p aprender-train --lib step_profiler 30/30; cargo fmt --check clean; cargo clippy -p aprender-train --lib -D warnings clean. Output-equivalence by literals, not a byte diff: format/string literals in the non-test part of step_profiler.rs are identical to main except two additions ('{json}', 'launch'), consistent with the json_report extraction. Not run: mutation, CUDA trainer paths, full CI. Not armed.

@github-actions

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5827 head=ec21dfc42fec85b0379cc72703f21990b5de87a9 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seat 2 (aprender-pace, claude-sonnet-5-5, non-author): APPROVE @ec21dfc42fec85b0379cc72703f21990b5de87a9. Reviewed the full step_profiler.rs diff by reading; not built or run by me (aprender-triage-worker's earlier run: step_profiler 30/30). print_report split: the per-layer and percentile blocks moved verbatim into helpers with the same guards (num_layers==0||step_count==0 return; len<10 return) and the same format strings. json_report: step_count==0 returns None and print_json_report returns as before; phases/layers/ops/bottleneck were already computed from the same fields; bottleneck total_us<=0 gives launch as before (forward 0, transfer 0); gemm sum has the same 7 terms; the emitted string is unchanged. Not run: mutation, CUDA paths, full CI. Does not touch CI or the gate, so no ANDON. Not armed.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seat 2 (aprender-pace, claude-sonnet-5-5, non-author): APPROVE @56d95c5035e0f2e282e9f6066c49aa3abe628bf7. Re-bound: head moved from ec21dfc to 56d95c5 by a 'Merge branch main into work/5590-c' commit only; the PR's one file (step_profiler.rs) is byte-identical between the two heads (git diff empty), so the review above applies unchanged. Reading only, not built or run by me. No CI or gate change, no ANDON. Not armed.

noahgift added a commit that referenced this pull request Oct 21, 2026
…en (diff rc=0)

contracts.nt/shapes.ttl regen: pv extract contracts on a clean tree, git diff --exit-code rc=0.
QA-007 mutation is a manual cargo-test mutation, not cargo-mutants.
Sub-PRs folded: #5784 #5781 #5728 #5827.

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

Closed per Noah's 15:34Z ruling (verbatim via arbiter-cop). Tree diff: its 1 changed file has a blob identical in main or #5840 (blob compare vs origin/main and pr/5840): 1/1 covered.

@noahgift noahgift closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant