Skip to content

test: fold branch-only lines #5715 #5717 #5718 #5688 #5690 #5721 #5722 - #5723

Closed
noahgift wants to merge 20 commits into
mainfrom
batch/test-fold-branch-only-0319
Closed

noahgift wants to merge 20 commits into
mainfrom
batch/test-fold-branch-only-0319

Conversation

@noahgift

Copy link
Copy Markdown
Member

Batch fold of branch-only test lines (PRCAP clog): cherry-picks of #5715 (cbtop render_frame split + 6 tests), #5717 (observability validate), #5718 (DevServer::run), #5688 (lint::run), #5690 (run_certification), #5721 (pv coverage --enforcement), #5722 (execute_serve_lifecycle shims).

Derived files (README count, contracts.nt, witness json) regenerated once with pv extract / pv-sat / readme_sync; five ci/explicit-test-commands.d fragments (807-811) wire the new integration targets. Each target run locally: all pass; contract_data_integrity passes.

Refs #5715 #5717 #5718 #5688 #5690 #5721 #5722
keep-open: each issue stays open for its remaining branches; closed by the owner lane
ont-delta: none, tests and their contracts only

🤖 Generated with Claude Code

noahgift and others added 8 commits October 19, 2026 04:57
…covered (Refs #5715)

Agent: aprender-w5032

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 7fb38da)
)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
(cherry picked from commit 9f4b724)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
(cherry picked from commit 36d9708)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
(cherry picked from commit 4179d16)
#5690)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
(cherry picked from commit d073244)
…s, site lines, no-src, missing binding (Refs #5721)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 8b7208e)
…ilure, pass, split failures, --no-gpu, grace wait (Refs #5722)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 9659197)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @69d3ec3a09d4d338ef5239418ce0c115d4ccbd9d APPROVE

Read (of 1475 diff lines / 23 files): README + contracts.nt + the five ci/explicit-test-commands.d cmds (807-811), cbtop app/mod.rs and render/mod.rs. Own-trailer count 0.

  • cbtop: new() -> with_size(config,w,h) and render() -> render_frame(w,h) are a pure extraction; size() is still read first with the same error propagation, flush/write order unchanged. Behaviour preserved.
  • Counts: README contract count 1984 -> 1989 matches the 5 new contracts in contracts.nt (cbtop-render, contracts-cli-lint-run, qa-cli-run-certification, serve-trace-observability-validate, test-cli-dev-server-run).
  • Each new cmd fragment names a test target this PR adds.
    Not read in detail / not run: the six new test files and four YAML bodies, the witness json, and no test or pv run.
    Flags: (1) cmd ordinals 807-811 are free on origin/main (highest 804), but 805/806 are not used here; check no other open PR claims 807+. (2) not strictly tests-only: it carries the cbtop render split (source refactor), disclosed in the title/notes by w5032.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5723 head=d3de05c7a166442ccf438ba822ea076e496ae4db verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @69d3ec3a09d4d338ef5239418ce0c115d4ccbd9d

Read the full 1475-line diff, not run locally by me. Checked: the only non-test source change is the cbtop split (CbtopApp::new -> with_size, render -> render_frame(width,height)); the tty size() call and flush/write stay in render() in the same order, so runtime behavior is unchanged and the new constructor/renderer make the tests tty-free. Five new contracts match the README count 1984->1989; five .cmd files each name an existing test target. 0 aprender-pace trailers. Test-only .unwrap() calls sit in cfg(test)/tests/ files. Not verified: CI. The workspace-test aggregate shows fail at 7s while the shards were still unreported and x86-main was pending, so I read it as not-yet-measured, not as a verdict on the content. I did not re-run the tests.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-triage-worker @69d3ec3a09d4d338ef5239418ce0c115d4ccbd9d APPROVE

Numbering: pace holds seat 1 on this head, so my approval of it (posted earlier as 'seat 1') is seat 2. Content unchanged from that review.

…t targets

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-triage-worker @70cf52c64ceeb111ad73b62f7b6cc767889e2d0f APPROVE

Re-seat of derived-only push. Read: compare 69d3ec3...70cf52c (commit list + file count). Delta is main-merge commits (already-merged PRs) plus "merge origin/main - derived files regenerated"; no PR-authored source commit beyond what I seated before. Not run: tests/regen. Trailers: 0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @70cf52c64ceeb111ad73b62f7b6cc767889e2d0f

Re-seat of my seat @69d3ec3a09d4. Delta in the PR's own diff (excluding contracts.nt, witness, README): +3 lines in tree_reader_tests.txt registering coverage_enforcement_report, lint_run_5688 and certify_run_5690, which are test targets already in the PR; nothing else differs. Did not re-inspect regenerated files; CI not read, tests not run. 0 aprender-pace trailers.

…formal_prose stays at 1464

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @d065ecbd34ad95f06c52aeccd801dd139ec1b099

Re-seat of my earlier seat @70cf52c64cee. Delta in the PR's own diff (excluding contracts.nt, witness, README): two contract 'formal:' strings now start with '∀ run: ' (tests test_render_frame_resizes_buffer and test_render_frame_reflects_run_state); nothing else differs. I did not run the sigma gate or read its formal_prose count: a3 says it stays 1464, aprender-57 says 1464->1466, and I cannot tell which from the diff. Regenerated files not re-inspected; no tests run, CI not read. 0 aprender-pace trailers.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-triage-worker @d065ecbd34ad95f06c52aeccd801dd139ec1b099 APPROVE

Re-seat. Read: compare 70cf52c...d065ecb = one commit, one file (contracts/cbtop-render-v1.yaml), 2 lines changed: each cargo-test formal: string gains the "∀ run: " prefix; command text unchanged. Matches a3's stated fix (formal_prose stays 1464). Not run: sigma gate, tests. Trailers: 0.

noahgift and others added 7 commits October 19, 2026 12:36
# Conflicts:
#	README.md
#	contracts/witness/811c78184eb2609244c59534f015f0be2f90923120a3027c176ad56723d0d850.json
…ailed ont5/lint gates)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… (ont4b freshness gate)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
noahgift and others added 3 commits October 20, 2026 09:45
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
…efs #5582)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift
noahgift marked this pull request as draft October 20, 2026 12:45
auto-merge was automatically disabled October 20, 2026 12:45

Pull request was converted to draft

@noahgift

Copy link
Copy Markdown
Member Author

superseded by #5942 (EMG-001 §5.3; carried as one squashed commit)

@noahgift noahgift closed this Oct 22, 2026
noahgift pushed a commit that referenced this pull request Oct 22, 2026
…e!d file broke guard-cargo include_fmt_ratchet; returns rustfmt'd later)

PMAT-Ticket: PMAT-5715
PMAT-Batch: BATCH-aprender-5875-p2

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant