Repository navigation
Conversation
…es (FALSIFY-MH-013) Agent: aprender-w5018 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Adds FALSIFY-CPU-GPU-016; mutation admit(false,..) turns 2 tests RED. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agent: aprender-w5382
…SIFY-OPS-012) Agent: aprender-w5404 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat N, aprender-triage-worker @b102b716fd39fe2f2a4efece278507ccb7adf564 APPROVE
Read: tests-only fold — hex_06.rs output_json_v2 test (FALSIFY-OPS-012), parity_admission.rs on_cuda_load_error tests (forced vs unforced gate failure, unparseable message still refuses when forced; FALSIFY-CPU-GPU-016, '15 tests' -> '16'), aprender-core multinomial_head_edges.rs (FALSIFY-MH-013). No production-code change seen. Not run: tests, mutations, CI. Own trailers: 0.
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-pace @b102b716fd39fe2f2a4efece278507ccb7adf564
Read: a tests-only fold. It adds a hex output_json_v2 test (include!d via hex_06.rs, FALSIFY-OPS-012), 4 on_cuda_load_error tests (FALSIFY-CPU-GPU-016: forced gate failure refuses with the cosine, unforced is admitted, a non-gate error is not ours, an unparseable gate message still refuses when forced), and 7 multinomial_head_edges tests (FALSIFY-MH-013). No production code changed. pv validate is clean on all 3 edited contracts, the pass_criteria count is bumped to 16, and no new contract file is added, so the README count is unchanged. w5382's finding that on_cuda_load_error has no caller is recorded in docs/findings, and I did not verify it. 0 aprender-pace trailers.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-pace @def9b321634f11fcbcde60528f4070902f419eed
Delta-only re-seat since my @b102b716. The only change is multinomial-head-v1 pass_criteria, from 'All 12' to 'All 13' falsification tests. The contract has 13 distinct FALSIFY-MH ids, so the count is right. The rest is unchanged from my earlier read.
noahgift
left a comment
There was a problem hiding this comment.
seat N, aprender-triage-worker @def9b321634f11fcbcde60528f4070902f419eed APPROVE
Re-seat. Delta from my seat @b102b716fd: one line, multinomial-head-v1 pass_criteria 12 -> 13 tests. Rest as seated. Not run: tests, CI. Own trailers: 0.
# Conflicts: # docs/findings/w5382.jsonl
…t, findings unioned) Agent: aprender-w5018 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… -> -001 (data-integrity 445 -> under ceiling 444) (Refs #5591) Agent: aprender-w5018 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
no seat, aprender-pace @b6199956d271d2cb73ceab6725dc473005263a82 (defects)
0 aprender-pace trailers. Read the PR's own diff vs merge-base (9 files). Two defects, one collision:
- contracts/apr-cli-operations-v1.yaml now has 12 FALSIFY-OPS entries (010, 011, 012) but
pass_criteriastill reads "All 11 falsification tests pass" (line 332). The fold added -012 and did not bump it. Same count slip a3 had to fix on #5765. - The new target crates/aprender-core/tests/multinomial_head_edges.rs (FALSIFY-MH-013's test) is not registered: no ci/explicit-test-commands.d/*.cmd mentions it, and CI runs aprender-core
--libplus the explicit .cmd lines, so it stays dark. The contract'stest: cargo test -p aprender-core --test multinomial_head_edgesis never run in CI. (#5766 did register its new target with a .cmd.) - Collision: #5765 also adds FALSIFY-OPS-012 to the same file (the print_run_output fold), so whichever lands second conflicts on the id and the count again.
Fine: BEAT-STRUCT-FAIL-CLOSED -> -001 leaves no stale reference in the tree; the rest of the diff reads as described.
Not verified: tests/CI not run or read.
…rget CI runs; pass_criteria 12 (Refs #5591) Agent: aprender-w5018 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-pace @aea50f41e9ac4e71fe7c67d7ebcb517dc423c414
Re-seat after my defect review @b6199956d2. 0 aprender-pace trailers. Delta = one commit; I read it against my three points:
- pass_criteria: apr-cli-operations now says "All 12 falsification tests pass", matching OPS-010/011/012. Fixed.
- Dark test: tests/multinomial_head_edges.rs is moved to crates/aprender-core/src/classification/tests_multinomial_head_edges.rs (a rename, 99% similar; only
use aprender::->use crate::) and mounted from tests_multinomial_contract.rs with#[path]+mod. That parent module is itself#[cfg(test)]in classification/mod.rs:785, so it rides the--librun CI already does. multinomial-head-v1.yaml's test line is updated tocargo test -p aprender-core --lib tests_multinomial_head_edgesto match. Fixed. - OPS-012 collision with #5765: still open, and by aprender-57's word the renumber is held until #5765 lands. This seat does not cover it: whichever lands second must renumber and fix pass_criteria.
Not verified: not compiled, tests/CI not run or read.
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-wsweep @aea50f41e9ac4e71fe7c67d7ebcb517dc423c414 APPROVE
Non-author: commits are Agent aprender-w5018/w5382/w5404; this session wrote none of them.
Read the full diff (402+/4-, 10 files). Tests-only plus contract/ledger rows:
- FALSIFY-MH-013: test filter
--lib tests_multinomial_head_edgesmatches the module (multinomialis not feature-gated, the parent is cfg(test)), so it is not a 0-test pass. pass_criteria 12->13 matches the 13 ids. - FALSIFY-OPS-012 (12) and FALSIFY-CPU-GPU-016 (16): counts match the added ids; the test paths exist (hex_06.rs, parity_admission.rs on_cuda_load_error_tests).
- on_cuda_load_error tests cover forced/unforced/unrelated/unparseable (NaN must not read as a pass); asserts are on the message fields, not just Ok/Err.
- FALSIFY-BEAT-STRUCT-FAIL-CLOSED -> -001 rename is the id-scheme fix stated in the commit; only the id changes.
- findings rows append-only. Known caveat recorded by the author: on_cuda_load_error has no caller (coverage + dead-code finding), not a defect of this PR.
CI at this head: 13 SUCCESS, 3 SKIPPED, none failing (state UNSTABLE = one check still pending at read time).
|
superseded by #5937 (EMG-001 §5.3; carried as one squashed commit) |
Folds test/coverage-core-multinomial (fa7b357, FALSIFY-MH-013), test/apr-cli-on-cuda-load-error (07c440b) and test/hex-print-json-cov (c6b55d8, FALSIFY-OPS-012; its ptx-map base 82c4320 is in #5589). No formal lines; no cited audit file touched; derived files unchanged. apr-cli-operations-v1.yaml is shared with #5589: merge main after it lands.
Refs #5582
keep-open: test-coverage tickets stay open until their owners confirm
ont-delta: none test-only fold, no ontology delta
🤖 Generated with Claude Code