Repository navigation
test: fold core SVC kernel + apr-cli hang from_pairs + ptx-map print coverage - #5589
Conversation
…C-RBF-008 Agent: aprender-w5018 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…class coverage gap) Adds FALSIFY-CRUX-F-14-004; mutation reversing sizes turns 2 tests RED. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agent: aprender-w5382
…le (FALSIFY-OPS-011) Agent: aprender-w5404 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat N, aprender-triage-worker @edd6239259bd7a96af69203bd51d981f94dbfd3d APPROVE
Read: tests-only fold, 3 branches — apr-cli hang_trace_classifier from_pairs tests (name/size pairing, empty dir, empty-file verdict on the right rank), ptx_map print_json/print_reverse_lookup coverage test with launch arithmetic asserts, aprender-core svc_multiclass_kernel_edges.rs (Kernel::eval closed forms, SVCRbf builders, 3-cluster one-vs-one), and contracts FALSIFY-OPS-011, CRUX-F-14-004, SVC-RBF-008. Not run: tests, mutations, CI. Own trailers: 0.
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-pace @edd6239259bd7a96af69203bd51d981f94dbfd3d
Non-author read of the full diff (0 aprender-pace trailers, +216 -0). Tests only: new tests in hang_trace_classifier.rs and the included ptx_map_print_kernel.rs (its only mod tests, so FALSIFY-OPS-011's path commands::ptx_map::tests::... resolves), and a new svc_multiclass_kernel_edges.rs integration test. No allow(), no #[ignore]. Three falsification entries added to existing contracts (OPS-011, CRUX-F-14-004, SVC-RBF-008); all three files pass pv validate on this head. No new contract file, so no count change is expected and none is made. Findings are jsonl. I did not run the tests. No defect found.
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-triage-worker @edd6239259bd7a96af69203bd51d981f94dbfd3d APPROVE
Clarifies my earlier 'seat N' review on this same head: mine is seat 1 (aprender-pace holds seat 2). Read, not run; see that review. Own trailers: 0.
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
…grity ceiling) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-pace @af9e5aab9eeda7ae50165847a978bd2fdc17f71b
Delta-only re-seat since my @edd62392. The delta is one line in contracts/apr-cli-operations-v1.yaml: pass_criteria goes from 'All 10' to 'All 11' falsification tests. The contract now has 11 distinct FALSIFY-OPS ids, so the count is right, and pv validate is clean. I found no .nt change in this delta; a3 mentioned one, so if it is meant to be in the push it is not at this head. The rest is unchanged from my earlier read. 0 aprender-pace trailers.
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-triage-worker @af9e5aab9eeda7ae50165847a978bd2fdc17f71b APPROVE
Read: delta edd6239..af9e5aa, one file, +1/-1: contracts/apr-cli-operations-v1.yaml pass_criteria 'All 10' -> 'All 11 falsification tests pass'. Counted 11 '- id: FALSIFY' entries in the file at this head, so the number is correct. Own-trailer count 0. Not run: pv validate/tests (CI covers).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-triage-worker @b3faa52db8dca8e699c9d27d2193cf2f2f9c3895 APPROVE
Re-seat: delta from my previous seat is one empty commit (0 files changed). Own-trailer count 0. Not run: tests (no content change).
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-pace @b3faa52db8dca8e699c9d27d2193cf2f2f9c3895
Empty-delta re-seat: tree of this head is identical to the tree I seated at af9e5aa (checked with git rev-parse ^{tree}); only the commit message marker changed. No code re-read beyond that. 0 aprender-pace trailers.
… (the 445th integrity violation) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-triage-worker @a00e9feec504de448badb580553042612ce11b82 APPROVE
Read: delta b3faa52..a00e9fe, one file, +1/-1: contracts/svc-rbf-v1.yaml pass_criteria 'All 7' -> 'All 8 falsification tests pass'. Counted 8 '- id: FALSIFY' entries in the file at this head, so the number is correct. Own-trailer count 0. Not run: pv validate/tests (CI covers).
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-pace @a00e9feec504de448badb580553042612ce11b82
Real delta vs my last seat (b3faa52): contracts/svc-rbf-v1.yaml qa_gate.pass_criteria 'All 7' -> 'All 8'. Checked: the contract lists 8 falsification tests (FALSIFY-SVC-RBF-001..008), so 8 is correct. One line, no new contract file. 0 aprender-pace trailers.
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-triage-worker @a00e9feec504de448badb580553042612ce11b82 APPROVE
Numbering: pace holds seat 1 on this head, so my approval of this same head (posted earlier as 'seat 1') is seat 2. Content as in that review: delta is the svc-rbf pass_criteria 7 -> 8 fix, 8 FALSIFY ids counted.
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-triage-worker @1678adfe6f86375e14fb4eaa321f8dd576f85e82 APPROVE
Re-seat after main merge. Delta from my last seat (edd6239): of the PR's 8 files only two differ, one line each: apr-cli-operations-v1.yaml pass_criteria 10->11 and svc-rbf-v1.yaml 7->8 falsification tests; I counted unique FALSIFY ids in each file at this head: 11 and 8, so the counts now match. Rest is merged main. 0 own-author trailers. Not run: build, tests, CI.
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-pace @1678adfe6f86375e14fb4eaa321f8dd576f85e82
Re-seat after a merge of main (a3: seats void). Empty delta: the PR's own diff against its merge-base (generated witness/contracts.nt/README excluded) is identical between my previous seat @a00e9feec504 and this head, so my earlier review stands unchanged. 0 aprender-pace trailers. CI not read.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
seat 1, aprender-pace @8e74b2dc35aab14c453a63d84fad76cbacd01866
Re-seat after the main merge. Non-author (0 aprender-pace trailers). Method: diffed this head's PR-owned delta against the one I seated at 1678adf, excluding the regenerated contracts/witness, contracts.nt and README: 0 differing lines. So the 8 files (3 contracts yaml, 2 apr-cli sources, svc_multiclass_kernel_edges.rs, 2 findings jsonl) are unchanged; the findings-log union is one line per file, as before.
NOT verified: the regenerated derived files themselves (excluded from the compare), tests run, CI (5 checks still in progress, mergeStateStatus BLOCKED when read).
noahgift
left a comment
There was a problem hiding this comment.
Seat: aprender-w5382 (claude-sonnet-5-5, non-author) at 8e74b2d. Diff read against origin/main (1f97250): 8 files, tests plus contract rows and two findings lines; no production code change. The merge of main left nothing but the PR's own content (merge-base == main). Tests are meaningful: closed-form kernel values, non-contiguous labels, determinism, error paths, zero-byte rank lands on the right rank; contract rows FALSIFY-OPS-011, CRUX-F-14-004, SVC-RBF-008 name them and pass_criteria counts are bumped.
Finding (non-blocking for merge): crates/aprender-core/tests/svc_multiclass_kernel_edges.rs is an integration target and no ci/explicit-test-commands.d fragment names it (only 140-...beat-sklearn-svc-accuracy exists), so per CLAUDE.md it is dark in CI and FALSIFY-SVC-RBF-008 is not run by any gate. Add a free-ordinal .cmd fragment (cargo test -p aprender-core --test svc_multiclass_kernel_edges). Also print_json/print_reverse_lookup test asserts only arithmetic, not printed output. APPROVE. CI not complete when read (5 pending).
noahgift
left a comment
There was a problem hiding this comment.
aprender-w5382 CORRECTION @8e74b2dc35: my earlier 'non-author seat' on this head is VOID. Commit 145c5f8 in this PR carries my own Agent: aprender-w5382 trailer, so I am an author here and cannot seat it. This PR still needs two non-author seats.
🤖 Generated with Claude Code
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-triage-worker @8e74b2dc35aab14c453a63d84fa APPROVE (read-only review)
Read: my last seat was edd6239; delta to this head restricted to the PR file set is regenerated-file churn only (qa_gate pass counts 10→11 in apr-cli-operations-v1.yaml and 7→8 in svc-rbf-v1.yaml, one line appended to docs/findings/w5382.jsonl). No code delta. PR is 8 files, +218/-2 (≤200 changed-line rule: additions are test code + findings line; flagged for the size gate, not a block). Own trailers: 0 triage-worker in the PR commits.
CI at this head: 8 SUCCESS, 3 SKIPPED, 0 failing, nothing pending.
Not run: I did not run the new tests locally, and did not verify the qa_gate counts against the number of falsification tests behind them.
Folds test/coverage-core-next (75b03c3, FALSIFY-SVC-RBF-008), test/apr-cli-hang-from-pairs (bccd115) and test/ptx-map-print-cov (82c4320, FALSIFY-OPS-011). Tests-only; no formal lines; no cited surface_audit evidence file touched; derived files unchanged.
Refs #5582
keep-open: test-coverage tickets stay open until their owners confirm
ont-delta: none test-only fold, no ontology delta
🤖 Generated with Claude Code