Repository navigation
DO NOT MERGE: Verify Playwright failure artifacts in CI - #529
fantonangeli wants to merge 2 commits into
Conversation
Related to open-workflow-specification#524 Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Append intentional failing expectations and continue recursive CI builds so both packages can produce failure artifacts. Do not merge this commit. Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
There was a problem hiding this comment.
🔵 Needs a closer look
Confirming downloadable screenshots, videos, and traces for both intentionally failing packages across Linux, macOS, and Windows requires inspecting actual CI artifacts, which source review alone cannot verify.
No open issues 🎉
What changed in this PR
This CI-only validation PR supports #524 by enabling Playwright failure artifacts across all three editors. It is explicitly not intended to merge; the configuration changes will follow in a separate PR.
Changes:
- Enable failure screenshots and retain videos and traces for failed tests.
- Add intentional failures to existing Diagram Editor and Text Editor tests.
- Run the recursive CI build with
--no-bailso both packages can produce artifacts, reusing the existing upload step.
| File | Description |
|---|---|
packages/text-editor/tests-e2e/text-editor.spec.ts |
Add an intentional failure after warning-marker validation. |
packages/text-editor/playwright.config.ts |
Enable failure screenshots, videos, and traces. |
packages/open-workflow-diagram-editor/tests-e2e/validation-error.spec.ts |
Add an intentional failure after nested-task error validation. |
packages/open-workflow-diagram-editor/playwright.config.ts |
Enable failure screenshots, videos, and traces. |
packages/dual-editor/playwright.config.ts |
Enable failure screenshots, videos, and traces. |
.github/workflows/ci_build.yaml |
Continue recursive builds after package failures to collect artifacts. |
Review effort: Balanced
Related to #524
❗ CI validation only. Do not merge this PR.
Enable failure screenshots, videos, and traces in the Text Editor, Diagram Editor, and Dual Editor Playwright configurations.
Append an intentionally failing
expectat the end of these tests:a nested task's error marks the child node, not its container.replacing OWS-invalid JSON with a valid workflow removes warning markers.Temporarily run the recursive CI build with
--no-bailso both packages can produce failure artifacts. Reuse the existing artifact upload step.A separate PR will contain only the
playwright.config.tschanges. Close this PR after validation.