Skip to content

DO NOT MERGE: Verify Playwright failure artifacts in CI - #529

Closed
fantonangeli wants to merge 2 commits into
open-workflow-specification:mainfrom
fantonangeli:issue-524-playwright-artifacts-verification
Closed

fantonangeli wants to merge 2 commits into
open-workflow-specification:mainfrom
fantonangeli:issue-524-playwright-artifacts-verification

Conversation

@fantonangeli

@fantonangeli fantonangeli commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Related to #524

❗ CI validation only. Do not merge this PR.

Enable failure screenshots, videos, and traces in the Text Editor, Diagram Editor, and Dual Editor Playwright configurations.

Append an intentionally failing expect at the end of these tests:

  • Diagram Editor: a nested task's error marks the child node, not its container.
  • Text Editor: replacing OWS-invalid JSON with a valid workflow removes warning markers.

Temporarily run the recursive CI build with --no-bail so both packages can produce failure artifacts. Reuse the existing artifact upload step.

A separate PR will contain only the playwright.config.ts changes. Close this PR after validation.

Related to open-workflow-specification#524

Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Append intentional failing expectations and continue recursive CI builds so
both packages can produce failure artifacts. Do not merge this commit.

Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 13:24
@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor ready!

Name Link
🔨 Latest commit 8ee2845
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6af31b02e53e78222c080778
😎 Deploy Preview https://deploy-preview-529--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8ee2845

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Confirming downloadable screenshots, videos, and traces for both intentionally failing packages across Linux, macOS, and Windows requires inspecting actual CI artifacts, which source review alone cannot verify.

No open issues 🎉

What changed in this PR

This CI-only validation PR supports #524 by enabling Playwright failure artifacts across all three editors. It is explicitly not intended to merge; the configuration changes will follow in a separate PR.

Changes:

  • Enable failure screenshots and retain videos and traces for failed tests.
  • Add intentional failures to existing Diagram Editor and Text Editor tests.
  • Run the recursive CI build with --no-bail so both packages can produce artifacts, reusing the existing upload step.
File Description
packages/​text-editor/​tests-e2e/​text-editor.spec.ts Add an intentional failure after warning-marker validation.
packages/​text-editor/​playwright.config.ts Enable failure screenshots, videos, and traces.
packages/​open-workflow-diagram-editor/​tests-e2e/​validation-error.spec.ts Add an intentional failure after nested-task error validation.
packages/​open-workflow-diagram-editor/​playwright.config.ts Enable failure screenshots, videos, and traces.
packages/​dual-editor/​playwright.config.ts Enable failure screenshots, videos, and traces.
.github/​workflows/​ci_build.yaml Continue recursive builds after package failures to collect artifacts.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants