Repository navigation
feat: Capture Playwright artifacts on E2E test failures - #530
Conversation
Related to open-workflow-specification#524 Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change enabling Playwright failure artifacts across all three editors.
No open issues 🎉
What changed in this PR
Enables Playwright failure artifacts across all three editors to help diagnose E2E failures, addressing #524 without changing CI infrastructure.
Changes:
- Captures screenshots only when tests fail.
- Records videos and traces, retaining them only for failed tests.
- Applies the same settings to the Text Editor, Diagram Editor, and Dual Editor configurations.
| File | Description |
|---|---|
packages/text-editor/playwright.config.ts |
Enables screenshots, videos, and traces for failed Text Editor tests. |
packages/open-workflow-diagram-editor/playwright.config.ts |
Enables screenshots, videos, and traces for failed Diagram Editor tests. |
packages/dual-editor/playwright.config.ts |
Enables screenshots, videos, and traces for failed Dual Editor tests. |
Review effort: Balanced
|
@lornakelly can you please merge? |
70578c7
into
open-workflow-specification:main
Closes #524
Enable screenshots, video recordings, and traces on E2E test failures in the Text Editor, Diagram Editor, and Dual Editor Playwright configurations. The existing CI artifact upload step collects these files to help debug failing tests.
This PR contains only the three
playwright.config.tschanges. Artifact generation and upload can be verified using the intentional failures in the companion PR #529.How to test:
Open the CI run. In Artifacts, download and extract
playwright-ubuntu-latest.Locate the failed-test folders under:
open-workflow-diagram-editor/test-results/text-editor/test-results/For each intentionally failing test, verify that the folder contains:
test-failed-1.pngvideo.webmtrace.zipOpen each screenshot and play each video.
Open Playwright Trace Viewer and drag in one
trace.zipat a time, keeping it zipped. Repeat for both tests.Repeat steps 1–4 with
playwright-macos-latestandplaywright-windows-latest. All artifacts can be inspected on your local machine, regardless of the runner OS.Expected result: screenshots, videos, and readable traces are available for both intentional failures on all three operating systems.
Preview:
Playwright recording from CI:
video.webm
Playwright Trace Viewer locally (recorded by me):
https://github.com/user-attachments/assets/0955fb79-0410-4fa2-a99b-a47a9c69d55a