Skip to content

feat: Capture Playwright artifacts on E2E test failures - #530

Merged
lornakelly merged 1 commit into
open-workflow-specification:mainfrom
fantonangeli:issue-524-playwright-failure-artifacts
Nov 11, 2026
Merged

lornakelly merged 1 commit into
open-workflow-specification:mainfrom
fantonangeli:issue-524-playwright-failure-artifacts

Conversation

@fantonangeli

@fantonangeli fantonangeli commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Closes #524

Enable screenshots, video recordings, and traces on E2E test failures in the Text Editor, Diagram Editor, and Dual Editor Playwright configurations. The existing CI artifact upload step collects these files to help debug failing tests.

This PR contains only the three playwright.config.ts changes. Artifact generation and upload can be verified using the intentional failures in the companion PR #529.

How to test:

  1. Open the CI run. In Artifacts, download and extract playwright-ubuntu-latest.

  2. Locate the failed-test folders under:

    • open-workflow-diagram-editor/test-results/
    • text-editor/test-results/

    For each intentionally failing test, verify that the folder contains:

    • test-failed-1.png
    • video.webm
    • trace.zip
  3. Open each screenshot and play each video.

  4. Open Playwright Trace Viewer and drag in one trace.zip at a time, keeping it zipped. Repeat for both tests.

  5. Repeat steps 1–4 with playwright-macos-latest and playwright-windows-latest. All artifacts can be inspected on your local machine, regardless of the runner OS.

Expected result: screenshots, videos, and readable traces are available for both intentional failures on all three operating systems.

Preview:

Playwright recording from CI:
video.webm

Playwright Trace Viewer locally (recorded by me):
https://github.com/user-attachments/assets/0955fb79-0410-4fa2-a99b-a47a9c69d55a

Related to open-workflow-specification#524

Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 14:04
@netlify

netlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor ready!

Name Link
🔨 Latest commit 134d630
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6af3245f4491f1ed786c07da
😎 Deploy Preview https://deploy-preview-530--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 134d630

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change enabling Playwright failure artifacts across all three editors.

No open issues 🎉

What changed in this PR

Enables Playwright failure artifacts across all three editors to help diagnose E2E failures, addressing #524 without changing CI infrastructure.

Changes:

  • Captures screenshots only when tests fail.
  • Records videos and traces, retaining them only for failed tests.
  • Applies the same settings to the Text Editor, Diagram Editor, and Dual Editor configurations.
File Description
packages/​text-editor/​playwright.config.ts Enables screenshots, videos, and traces for failed Text Editor tests.
packages/​open-workflow-diagram-editor/​playwright.config.ts Enables screenshots, videos, and traces for failed Diagram Editor tests.
packages/​dual-editor/​playwright.config.ts Enables screenshots, videos, and traces for failed Dual Editor tests.

Review effort: Balanced

@fantonangeli fantonangeli added the github_actions Pull requests that update GitHub Actions code label Nov 10, 2026

@lornakelly lornakelly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@fantonangeli

Copy link
Copy Markdown
Member Author

@lornakelly can you please merge?

@lornakelly
lornakelly merged commit 70578c7 into open-workflow-specification:main Nov 11, 2026
13 checks passed
@fantonangeli
fantonangeli deleted the issue-524-playwright-failure-artifacts branch November 11, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Capture Playwright artifacts on E2E test failures

4 participants