Repository navigation
DO NOT MERGE: Verify Dual Editor Netlify preview - #527
fantonangeli wants to merge 2 commits into
Conversation
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
|
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🔵 Needs a closer look
Required validation remains outstanding because the Netlify Deploy Preview is pending and the deployed Dual Editor Storybook has not yet been confirmed to display “updated” below the Welcome heading.
No open issues 🎉
What changed in this PR
This preview-only companion to #526 switches Netlify to the Dual Editor Storybook and adds a visible marker for validation of #525. It should be closed after validation, not merged; the production change remains in #526.
Changes:
- Configures Netlify to build the Dual Editor and publish its Storybook output.
- Adds
updatedbelow the Welcome heading to trigger the package-based preview filter and identify the updated preview.
| File | Description |
|---|---|
packages/dual-editor/stories/introduction/Welcome.mdx |
Adds the temporary updated validation marker below the title. |
netlify.toml |
Changes the preview build package and publish directory to the Dual Editor. |
Review effort: Balanced
|
@lornakelly should we have a label for "DO NOT MERGE" PRs like here? |
Created and added, thanks |
|
#526 has been closed and will be re-evaluated in the future |
Related to #525
❗ Preview-only companion to #526. Do not merge this PR.
Includes the same
netlify.tomlchange as #526 and addsupdatedimmediately below the title inpackages/dual-editor/stories/introduction/Welcome.mdx. The package change is intended to pass the existingignorefilter and trigger a Netlify Deploy Preview.Use the Netlify preview link on this PR to verify that the Dual Editor Storybook is published and that the Welcome page displays
updatedbelow the heading. Keep the production change in #526; close this PR after validation.