Repository navigation
feat: Switch Netlify previews to the Dual Editor - #526
fantonangeli wants to merge 1 commit into
Conversation
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for openworkflow-editor canceled.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the Netlify configuration change targeting Dual Editor previews.
No open issues 🎉
What changed in this PR
Switches Netlify Storybook previews from the standalone Diagram Editor to the Dual Editor, addressing the deployment configuration portion of #525.
Changes:
- Sets the preview build target to
@openworkflowspec/dual-editor. - Publishes Storybook from
packages/dual-editor/dist-storybook.
| File | Description |
|---|---|
netlify.toml |
Updates the preview package and publish directory to use the Dual Editor. |
Review effort: Balanced
There was a problem hiding this comment.
@fantonangeli this would mean we always show the dual-editor? Currently the dual editor has the MVP of the diagram editor so we will not be able to preview the feature branch?
Later we can look into how we can potentially have both deployments served - maybe even a index page with both
Good point, @lornakelly . I would evaluate also adding the workflow scenarios from the Diagram Editor stories to the Dual Editor? We could share the workflow files between packages, while keeping component-specific stories in their respective Storybooks for specific testing (ie. Text Editor autocomplete). This would give us one Netlify preview without building and publishing all 3 Storybooks on every PR, avoiding possible Netlify quota limits. Wdyt? |
Yeah, good point on quota limits. I will create a ticket for investigation of options and implementation. For now focus on the more pressing tasks and we will come back to this |
|
@fantonangeli will close for now and reference in ticket |
Closes: #525
Updates
netlify.tomlto build@openworkflowspec/dual-editorand publishpackages/dual-editor/dist-storybook.The existing
ignorecommand may skip this configuration-only PR. PR #527 — DO NOT MERGE: Verify Dual Editor Netlify preview contains the same configuration plus anupdatedmarker below the Dual Editor Welcome heading, so the package change can trigger the Deploy Preview. Use the Netlify preview linked there to validate this change; only this PR should be merged.Validation: TOML syntax parsed successfully; package name, build script, and Storybook output directory checked against
packages/dual-editor/package.json.How to test:
Open the netlify preview link in #527
Preview:
Screencast.From.2026-11-09.18-14-25.mp4