Skip to content

feat: Switch Netlify previews to the Dual Editor - #526

Closed
fantonangeli wants to merge 1 commit into
open-workflow-specification:mainfrom
fantonangeli:issue-525-netlify-dual-editor
Closed

fantonangeli wants to merge 1 commit into
open-workflow-specification:mainfrom
fantonangeli:issue-525-netlify-dual-editor

Conversation

@fantonangeli

@fantonangeli fantonangeli commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Closes: #525

Updates netlify.toml to build @openworkflowspec/dual-editor and publish packages/dual-editor/dist-storybook.

The existing ignore command may skip this configuration-only PR. PR #527 — DO NOT MERGE: Verify Dual Editor Netlify preview contains the same configuration plus an updated marker below the Dual Editor Welcome heading, so the package change can trigger the Deploy Preview. Use the Netlify preview linked there to validate this change; only this PR should be merged.

Validation: TOML syntax parsed successfully; package name, build script, and Storybook output directory checked against packages/dual-editor/package.json.

How to test:

Open the netlify preview link in #527

Preview:

Screencast.From.2026-11-09.18-14-25.mp4

Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 17:07
@netlify

netlify Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor canceled.

Name Link
🔨 Latest commit e21b43a
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6af1fde78396a40d3446230b

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the Netlify configuration change targeting Dual Editor previews.

No open issues 🎉

What changed in this PR

Switches Netlify Storybook previews from the standalone Diagram Editor to the Dual Editor, addressing the deployment configuration portion of #525.

Changes:

  • Sets the preview build target to @openworkflowspec/dual-editor.
  • Publishes Storybook from packages/dual-editor/dist-storybook.
File Description
netlify.toml Updates the preview package and publish directory to use the Dual Editor.

Review effort: Balanced

@fantonangeli fantonangeli added the github_actions Pull requests that update GitHub Actions code label Nov 9, 2026

@lornakelly lornakelly left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fantonangeli this would mean we always show the dual-editor? Currently the dual editor has the MVP of the diagram editor so we will not be able to preview the feature branch?

Image

Later we can look into how we can potentially have both deployments served - maybe even a index page with both

@fantonangeli
fantonangeli marked this pull request as draft November 10, 2026 09:49
@fantonangeli

Copy link
Copy Markdown
Member Author

@fantonangeli this would mean we always show the dual-editor? Currently the dual editor has the MVP of the diagram editor so we will not be able to preview the feature branch?

Later we can look into how we can potentially have both deployments served - maybe even a index page with both

Good point, @lornakelly . I would evaluate also adding the workflow scenarios from the Diagram Editor stories to the Dual Editor?
This would let us test them through both editors and verify their functionalities, including the node-editing features once integrated.

We could share the workflow files between packages, while keeping component-specific stories in their respective Storybooks for specific testing (ie. Text Editor autocomplete).

This would give us one Netlify preview without building and publishing all 3 Storybooks on every PR, avoiding possible Netlify quota limits.

Wdyt?

@lornakelly

Copy link
Copy Markdown
Collaborator

@fantonangeli this would mean we always show the dual-editor? Currently the dual editor has the MVP of the diagram editor so we will not be able to preview the feature branch?

Later we can look into how we can potentially have both deployments served - maybe even a index page with both

Good point, @lornakelly . I would evaluate also adding the workflow scenarios from the Diagram Editor stories to the Dual Editor? This would let us test them through both editors and verify their functionalities, including the node-editing features once integrated.

We could share the workflow files between packages, while keeping component-specific stories in their respective Storybooks for specific testing (ie. Text Editor autocomplete).

This would give us one Netlify preview without building and publishing all 3 Storybooks on every PR, avoiding possible Netlify quota limits.

Wdyt?

Yeah, good point on quota limits. I will create a ticket for investigation of options and implementation. For now focus on the more pressing tasks and we will come back to this

@lornakelly

Copy link
Copy Markdown
Collaborator

@fantonangeli will close for now and reference in ticket

@lornakelly lornakelly closed this Nov 10, 2026
@fantonangeli
fantonangeli deleted the issue-525-netlify-dual-editor branch November 10, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Update Netlify previews to include the Diagram and the Dual Editor

3 participants