Repository navigation
feat: add resolve operator scenarios - #448
Open
marcozabel wants to merge 6 commits into
Open
marcozabel wants to merge 6 commits into
marcozabel wants to merge 6 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
marcozabel
marked this pull request as draft
November 11, 2026 15:06
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
marcozabel
force-pushed
the
feat/resolve-operator-scenarios
branch
from
November 11, 2026 15:30
63e18bc to
3687460
Compare
marcozabel
marked this pull request as ready for review
November 12, 2026 12:04
…e if Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
toddbaert
reviewed
Nov 16, 2026
toddbaert
left a comment
Member
There was a problem hiding this comment.
Coverage is thorough, on the right track! A few changes below to match the decisions in open-feature/flagd#2127.
toddbaert
reviewed
Nov 16, 2026
- drop `?:` flag and scenario - coerce boolean variants (literal and computed) instead of PARSE_ERROR - add a computed metadata key case - remove misplaced / malformed-literal scenarios (schema covers them) - keep resolve-flags.json out of allFlags.json; load it via a dedicated `resolve` launchpad config Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
marcozabel
force-pushed
the
feat/resolve-operator-scenarios
branch
from
November 17, 2026 10:06
a33df58 to
30351a4
Compare
- use a rule as the fractional bucketing value instead of a literal string - wrap the evaluator $ref in an if result instead of using it as the whole rule Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
This was referenced Nov 19, 2026
Rule metadata overwrites flag metadata, which overwrites flag set metadata. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
flagSetId and version are reserved for flag set metadata. The schema rejects them as literal resolve metadata keys, so only computed keys are covered; a literal key would make the shared flag file invalid. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
marcozabel
added a commit
to marcozabel/java-sdk-contrib
that referenced
this pull request
Nov 20, 2026
Pins open-feature/flagd-testbed#448 at 91ba87a. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
marcozabel
added a commit
to marcozabel/java-sdk-contrib
that referenced
this pull request
Nov 20, 2026
…rios Pins open-feature/flagd-testbed#448 at 952a05f (not pushed yet). Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds scenarios for the terminal
resolveoperator from the targeting metadata ADR, ingherkin/resolve.featurewith flags inflags/resolve-flags.json.Covered:
if, andfractionalbucketsGENERAL$refevaluator in anifresultTags and loading:
@resolve. Providers without the operator can exclude them withnot @resolve. Metadata scenarios are also tagged@metadata, and fallback scenarios@operator-errors.resolve-flags.jsonstays out ofallFlags.jsonand is loaded only through the newresolvelaunchpad config, so providers without the operator still accept the merged file.resolveisn't tested, because the targeting schema rejects it (feat: add terminal resolve operator to targeting schema flagd-schemas#238).Related Issues
Fixes #437
Part of open-feature/flagd#2090
Notes
The published image uses flagd v0.18.2, which doesn't have
resolve. The scenarios need open-feature/flagd#2127.Follow-up Tasks
How to test
npm run gherkin-lintgo test ./...inlaunchpadtest-harnessat this commit