Repository navigation
feat(flagd-core): add resolve operator - #1979
Draft
marcozabel wants to merge 11 commits into
Draft
marcozabel wants to merge 11 commits into
marcozabel wants to merge 11 commits into
Conversation
Temporarily pins open-feature/flagd-schemas#238 so the targeting schema knows resolve; move to the released schema before merging. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Selects a variant and optionally overrides the reason and merges rule metadata over flag and flag-set metadata. Malformed computed arguments fall back to the default variant. Part of open-feature#1924. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Temporarily pins open-feature/flagd-testbed#448. RPC excludes @resolve until the harness flagd image supports it. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Also splits the free-form reason case out of the placement test. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
github-actions
Bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
November 17, 2026 16:02
The schema rejects literal reserved keys only, so computed keys need a runtime check. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Picks up open-feature/flagd-schemas#238 review fixes: resolve can't be the first condition of a terminal if, and resolve mixes with plain if/fractional. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
Pins open-feature/flagd-testbed#448 at 91ba87a. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
The released test harness image has no "resolve" launchpad config, so starting it returns 500. File mode reads the harness flag file directly and no longer needs one; in-process skips resolve until the image ships it. Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
…rios Pins open-feature/flagd-testbed#448 at 952a05f (not pushed yet). Signed-off-by: marcozabel <marco.zabel@dynatrace.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the terminal
resolveoperator from the targeting metadata ADR in flagd-core, matching open-feature/flagd#2127.{"resolve": ["variant", "reason"?, [["key", value], ...]?]}selects a variant, optionally overrides the reason, and adds rule metadata (rule > flag > flag-set)ifresult, or afractionalbucket variant; placement is enforced by the targeting schemaGENERAL@resolvescenarios for in-process and file; RPC excludes them until the harness flagd supports itTemporarily pins the
schemasandtest-harnesssubmodules to open-feature/flagd-schemas#238 and open-feature/flagd-testbed#448; they move to the released versions before merge.Fixes #1924