Repository navigation
Bump flowkit to v2.17.0 - #2366
Merged
Merged
Conversation
Adds the aws-kms account key type, so account keys can be backed by an AWS KMS asymmetric key referenced by its ARN, the same way google-kms works. The aws-sdk-go-v2 modules arrive as indirect dependencies of flowkit.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
github.com/onflow/flowkit/v2fromv2.16.0tov2.17.0, which adds theaws-kmsaccount key type. Account keys can now be backed by an AWS KMS asymmetric key referenced by its ARN, the same waygoogle-kmsworks.No flow-cli code changes — the key type is resolved in flowkit. The
aws-sdk-go-v2modules arrive as indirect dependencies.Verification
go build ./...clean against the released moduleaws-kmsaccount loads and resolves on testnet, with the on-chain key matching the KMS keyhashAlgorithm: SHA3_256is rejected withinvalid hash algorithm for account ...: aws-kms keys only support SHA2_256Follow-up
The key type needs a line in the configuration docs — onflow/docs,
docs/build/tools/flow-cli/flow.json/configuration.mdlistsgoogle-kmsonly. That should land with this.