Repository navigation
Conversation
flowkit v2.17.0 adds an aws-kms key type alongside google-kms. The key types list in the flow.json reference only mentions Google Cloud KMS.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Naming the key type is not enough to use it: neither KMS entry said what resourceID holds, and an aws-kms key registered with the default SHA3_256 can never verify a KMS signature.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
aws-kmsto the account key types list in the flow.json reference, and explains whatresourceIDholds for both KMS types.Ready to merge
The dependency has landed: flowkit
v2.17.0adds the key type (onflow/flowkit#232) and onflow/flow-cli#2366 bumped flow-cli to it. Aflowbinary at currentmasteraccepts"type": "aws-kms".Why the extra paragraph
Naming a key type is not enough to use it. Neither KMS entry said what
resourceIDcontains, and anaws-kmskey registered on-chain with the defaultSHA3_256can never verify a KMS signature, because AWS KMS signs ECDSA keys withECDSA_SHA_256only. Both gaps cost real time during testing, so both are worth a sentence here.