Skip to content

E1.2: bind native process admission to retained identity state - #299

Merged
omry merged 1 commit into
pr297from
pr299
Oct 30, 2026
Merged

omry merged 1 commit into
pr297from
pr299

Conversation

@omry

@omry omry commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Add versioned native mapping state with admitted ID provenance separate from protected reservations. Preserve legacy supervisor reading and refuse automatic conversion of admitted or ambiguous authority.

Extend the existing checked operation journal with native active-map projection, immutable generation and image evidence, and a durable one-shot admission/release attempt. Preserve IDs and owned objects through uncertain writes and recovery; configure and recovery never manufacture admission. Add state, projection, stale-evidence and crash tests. Public mapped execution remains inhibited; engine/waiter transport belongs to E1.3.


Add versioned native mapping state with admitted ID provenance separate from protected reservations. Preserve legacy supervisor reading and refuse automatic conversion of admitted or ambiguous authority.

Extend the existing checked operation journal with native active-map projection, immutable generation and image evidence, and a durable one-shot admission/release attempt. Preserve IDs and owned objects through uncertain writes and recovery; configure and recovery never manufacture admission. Add state, projection, stale-evidence and crash tests. Public mapped execution remains inhibited; engine/waiter transport belongs to E1.3.
@omry
omry changed the base branch from main to pr297 October 28, 2026 15:32
@omry
omry added this pull request to stack #297 October 28, 2026 15:32
@gitar-bot

gitar-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🔴 High risk · Native-process admission commits mapped-ID provenance before release; mishandled identity state could authorize execution with unintended host-ID mappings.

Adds versioned native mapping state with admitted ID provenance separate from protected reservations, extending the operation journal with native active-map projection, generation and image evidence, and a durable one-shot admission/release attempt. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:5fc03080c8058c77e5c0d1b1cf43cdc5988391a9afc92f9d611a48b27fc4db4d",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:5fc03080c8058c77e5c0d1b1cf43cdc5988391a9afc92f9d611a48b27fc4db4d",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 122928789618
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 122917363657
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 122917360770
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 122917360822
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 122917361324
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 122917361017
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 122917360966
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 122917360846
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 122917361009
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:df0cc16f8890fa634da8cdd9ec73553b666621b2a03d08b58a038d179794fe8e",
      "review_request": {
        "body_digest": "sha256:0b6df976079bf060b69830d7d2a465ca9f3375255c30b08f055c1bc1ae94a262",
        "id": 6473502428
      },
      "review_result": {
        "body_digest": "sha256:c5ed5d15b229445cce869b6198237b0c24edd35f0090ffd377fc2d749a6f94b2",
        "id": 6473543465
      }
    },
    "evidence_fingerprint": "sha256:62b86251648397c675da974481b5ecc31a87c573334eddf622ebe31eefdb4684",
    "head_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
    "operation_identity": "sha256:df0cc16f8890fa634da8cdd9ec73553b666621b2a03d08b58a038d179794fe8e",
    "review_request_id": 6473502428,
    "review_result_id": 6473543465,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:5fc03080c8058c77e5c0d1b1cf43cdc5988391a9afc92f9d611a48b27fc4db4d",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Bash native evidence checks",
      "run_id": 122928789618
    },
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 122917363657
    },
    {
      "conclusion": "SUCCESS",
      "name": "Linux CI checks",
      "run_id": 122917360770
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-amd64)",
      "run_id": 122917360822
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-arm64)",
      "run_id": 122917361324
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-amd64)",
      "run_id": 122917361017
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-arm64)",
      "run_id": 122917360966
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-amd64)",
      "run_id": 122917360846
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-arm64)",
      "run_id": 122917361009
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 122928789618,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122928789618"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 122917363657,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/122917363657"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 122917360770,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917360770"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 122917360822,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917360822"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 122917361324,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917361324"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 122917361017,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917361017"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 122917360966,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917360966"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 122917360846,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917360846"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 122917361009,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/40717018402/job/122917361009"
        }
      ],
      "head_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
      "id": "sha256:35678cd62ad030a5069002aca54d3cc2ecfadaf665ff5da1db15d3ca798cf22e",
      "required_checks": [
        "Bash native evidence checks",
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr297",
    "base_sha": "3d7a3c718ca49228b0a1e55942f7525655e6573e",
    "body_digest": "sha256:c6f79341c5c15e6c780dc553e6447ed5838eafe43c36735b74bc43d202f61200",
    "body_identity_version": 2,
    "diff_digest": "sha256:0c33e8ef285af4330051fbc88756d0bafef6dbac5ec03c203840f557aadddcc5",
    "head_ref": "pr299",
    "head_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
    "pr": 299,
    "repository": "omry/reploy",
    "scope_authority": [
      {
        "digest": "sha256:36b1a52fb29e6424a689b1e2cae7e023371f878ca586f056fc28bc50450b87e6",
        "path": ".github/workflows/ci.yml"
      },
      {
        "digest": "sha256:fc49790f85e6d5fae77e8c91b479d0ad1fe4b3f1699e24df821db73aa75b779e",
        "path": "AGENTS.md"
      },
      {
        "digest": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
        "path": "docs/MULTI_IDENTITY_D_DESIGN.md"
      },
      {
        "digest": "sha256:ab5e9be8075947bc37c863545efb1959fa7aca886226018729bfeff6f7032e1e",
        "path": "docs/MULTI_IDENTITY_E_DESIGN.md"
      },
      {
        "digest": "sha256:3ef44a7a0be43648f5df1faad39b16101978662c58c87d6fa8e7409093a58fe9",
        "path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
      },
      {
        "digest": "sha256:fe188bb8a80f7f235e99b023283749a3a9e3172e4adf70b70b495d80e50e9218",
        "path": "docs/MULTI_IDENTITY_MAIL_RECONCILIATION.md"
      },
      {
        "digest": "sha256:b049714f4a85d0f3fb204615897374377690564627bfcdd03e50c945fb042826",
        "path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
      }
    ],
    "title_digest": "sha256:09f441d92539a9b99b221d19a32c4c77f9f4ca09f77b7806e307c550dd7f25c8"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-28T15:32:36Z",
      "base_ref": "pr297",
      "base_sha": "3d7a3c718ca49228b0a1e55942f7525655e6573e",
      "body_digest": "sha256:0b6df976079bf060b69830d7d2a465ca9f3375255c30b08f055c1bc1ae94a262",
      "created_at": "2026-10-28T15:42:20Z",
      "head_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
      "id": 6473502428,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr297",
      "base_sha": "3d7a3c718ca49228b0a1e55942f7525655e6573e",
      "body_digest": "sha256:c5ed5d15b229445cce869b6198237b0c24edd35f0090ffd377fc2d749a6f94b2",
      "commit_id": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
      "id": 6473543465,
      "inline_message_ids": [],
      "request_comment_id": 6473502428,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-28T15:44:01Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:5fc03080c8058c77e5c0d1b1cf43cdc5988391a9afc92f9d611a48b27fc4db4d",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:0c33e8ef285af4330051fbc88756d0bafef6dbac5ec03c203840f557aadddcc5",
      "finding_ids": [],
      "invariants": [
        "Protected reservations R do not prove admitted P; configure/recovery never manufacture native admission.",
        "Native A is independently derived from immutable image/generation and provenance; configure requires full C.",
        "Admission and one-shot owned release attempt commit atomically; uncertainty preserves IDs and ownership without replay.",
        "Legacy supervisor admissions remain reserved and cannot silently migrate; public mapped guards remain inhibited.",
        "Every exact-head ci.yml job must succeed before approval."
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
      "review_observation_id": null,
      "review_request_id": 6473502428,
      "review_result_id": 6473543465,
      "reviewed_head": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
      "root_cause": "No current-slice defect, design blocker, code correction or check retry. Local, independent and remote reviews are clean; complete current-head local validation and all nine checks passed.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review October 28, 2026 15:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T15:44:02.683641Z e4c4e57 Manual request
🔒 Security Review ✅ Completed 2026-10-28T15:43:49.760440Z e4c4e57 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Exact head: e4c4e57

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: e4c4e57b93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Oct 28, 2026
@omry
omry merged commit 493beff into main Oct 30, 2026
9 checks passed
@omry
omry deleted the pr299 branch October 30, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant