Repository navigation
Conversation
Add invocation-owned inhibited Podman waiter startup with exact immutable-image, owner/peer, runtime and kernel process checks. Reuse the existing native admission writer before a single bounded framed stdin handoff; retain uncertain ownership and clean up only the exact created instance. Preserve application stdin after the frame, keep admission deadlines separate from application lifetime, and reject missing proof, stale process evidence, unsupported streams and uncertain release. Add framing, real process/namespace and held-operation-lock callback tests. Public mapped execution remains inhibited; the qualified final exec transition and production storage/network admission remain E2/F gates.
Code Review ✅ Approved🔴 High risk · The new native-execution admission and mapped-container release could record approval and deliver application input under stale ownership or process evidence. Adds inhibited Podman waiter startup with exact immutable-image, owner/peer, runtime, and kernel process checks, reusing the native admission writer for a single bounded framed stdin handoff. No issues found. VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:cf126f4208467d510fd394e6e5984178a5b28919eb10fd1e7a44a92e26a9f316",
"evidence": {
"attestations": [],
"candidate_revision_fingerprint": "sha256:cf126f4208467d510fd394e6e5984178a5b28919eb10fd1e7a44a92e26a9f316",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 123090363139,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123090363139,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123068682413
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123087144155,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087144155,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123087145433,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145433,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123087218901,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087218901,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123087144292,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087144292,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123087145295,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145295,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123087143701,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087143701,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123087145193,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145193,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:aecc30771e3b745ffb7cde9ab54b08447cbb537a4f089ca4d596016e68364e59",
"review_request": {
"body_digest": "sha256:31adc480bb668e9f9fa6bc221b4cfb351254ff6c40344f8d743a6aee585324dc",
"id": 6479609424
},
"review_result": {
"body_digest": "sha256:4ac0c5b1377f71de6d9c39396417620ec4281b9b4593cc1c7ba4307f66b9ba0e",
"id": 6479650260
}
},
"evidence_fingerprint": "sha256:dbef4712ee6bb2ab0e181ba1013ead1f6378b2d56eeb524b8e728be2093e3ff7",
"head_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"operation_identity": "sha256:aecc30771e3b745ffb7cde9ab54b08447cbb537a4f089ca4d596016e68364e59",
"review_request_id": 6479609424,
"review_result_id": 6479650260,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:cf126f4208467d510fd394e6e5984178a5b28919eb10fd1e7a44a92e26a9f316",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 123090363139,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123090363139,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123068682413
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123087144155,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087144155,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123087145433,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145433,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123087218901,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087218901,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123087144292,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087144292,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123087145295,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145295,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123087143701,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087143701,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123087145193,
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145193,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
}
],
"check_observations": [
{
"checks": [
{
"conclusion": "SKIPPED",
"name": "Bash native evidence checks",
"run_id": 123081962193,
"run_status": "completed",
"status": "failure",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123081962193"
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123068682413,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/123068682413"
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123068676265,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676265"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123068676374,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676374"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123068676650,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676650"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123068676327,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676327"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123068676460,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676460"
},
{
"conclusion": "CANCELLED",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123068676552,
"run_status": "completed",
"status": "failure",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676552"
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123068676496,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123068676496"
}
],
"head_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"id": "sha256:32b5c7e6d99d10bab5a3336fc82c587962a83e7fdf51fd85d03eff8fdf7c8725",
"required_checks": [
"Bash native evidence checks",
"Gitar",
"Linux CI checks",
"Target smoke (darwin-amd64)",
"Target smoke (darwin-arm64)",
"Target smoke (linux-amd64)",
"Target smoke (linux-arm64)",
"Windows host smoke (windows-amd64)",
"Windows host smoke (windows-arm64)"
],
"status": "failure"
},
{
"checks": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 123090363139,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123090363139",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123090363139,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 123068682413,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/123068682413"
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 123087144155,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087144155",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087144155,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 123087145433,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087145433",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145433,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 123087218901,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087218901",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087218901,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 123087144292,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087144292",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087144292,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 123087145295,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087145295",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145295,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 123087143701,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087143701",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087143701,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 123087145193,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/40759899737/job/123087145193",
"workflow": {
"app_id": 15368,
"attempt": 2,
"check_suite_id": 110485936972,
"event": "pull_request",
"job_id": 123087145193,
"name_unique": true,
"run_id": 40759899737,
"workflow_id": 302865520
}
}
],
"head_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"id": "sha256:396e506dcbd4be4a502490c9257fbafa0ec6c160e75b5fd71bcbca3fad103986",
"required_checks": [
"Bash native evidence checks",
"Gitar",
"Linux CI checks",
"Target smoke (darwin-amd64)",
"Target smoke (darwin-arm64)",
"Target smoke (linux-amd64)",
"Target smoke (linux-arm64)",
"Windows host smoke (windows-amd64)",
"Windows host smoke (windows-arm64)"
],
"status": "success"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "pr299",
"base_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
"body_digest": "sha256:d04a11d9461f5158327a3d87361236d97f2d251c021e1287b243da9a58c36544",
"body_identity_version": 2,
"diff_digest": "sha256:56c7dd1e82b00445851a018fea660cdbb6c0f86c1e501912f4cc5ce79652ad5c",
"head_ref": "pr300",
"head_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"pr": 300,
"repository": "omry/reploy",
"scope_authority": [
{
"digest": "sha256:36b1a52fb29e6424a689b1e2cae7e023371f878ca586f056fc28bc50450b87e6",
"path": ".github/workflows/ci.yml"
},
{
"digest": "sha256:fc49790f85e6d5fae77e8c91b479d0ad1fe4b3f1699e24df821db73aa75b779e",
"path": "AGENTS.md"
},
{
"digest": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
"path": "docs/MULTI_IDENTITY_D_DESIGN.md"
},
{
"digest": "sha256:ab5e9be8075947bc37c863545efb1959fa7aca886226018729bfeff6f7032e1e",
"path": "docs/MULTI_IDENTITY_E_DESIGN.md"
},
{
"digest": "sha256:3ef44a7a0be43648f5df1faad39b16101978662c58c87d6fa8e7409093a58fe9",
"path": "docs/MULTI_IDENTITY_IMPLEMENTATION_PLAN.md"
},
{
"digest": "sha256:fe188bb8a80f7f235e99b023283749a3a9e3172e4adf70b70b495d80e50e9218",
"path": "docs/MULTI_IDENTITY_MAIL_RECONCILIATION.md"
},
{
"digest": "sha256:b049714f4a85d0f3fb204615897374377690564627bfcdd03e50c945fb042826",
"path": "docs/MULTI_IDENTITY_SECURITY_CONTRACT.md"
}
],
"title_digest": "sha256:7615e9f5760ea07dc7aa0f0bbfbdf9cddecf4f3bf41923e31abfc0c867da844f"
},
"record_version": 6,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-10-28T20:03:53Z",
"base_ref": "pr299",
"base_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
"body_digest": "sha256:31adc480bb668e9f9fa6bc221b4cfb351254ff6c40344f8d743a6aee585324dc",
"created_at": "2026-10-28T20:16:55Z",
"head_sha": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"id": 6479609424,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "pr299",
"base_sha": "e4c4e57b93ca7190b709678fc61e146f4e334c90",
"body_digest": "sha256:4ac0c5b1377f71de6d9c39396417620ec4281b9b4593cc1c7ba4307f66b9ba0e",
"commit_id": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"id": 6479650260,
"inline_message_ids": [],
"request_comment_id": 6479609424,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-10-28T20:18:17Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:cf126f4208467d510fd394e6e5984178a5b28919eb10fd1e7a44a92e26a9f316",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:56c7dd1e82b00445851a018fea660cdbb6c0f86c1e501912f4cc5ce79652ad5c",
"finding_ids": [],
"invariants": [
"Only exact owned immutable-image, complete kernel maps and pinned process/namespace evidence can admit native execution.",
"Durable native admission precedes one bounded release frame; no second release or ambiguous ownership cleanup.",
"Host observations that take OperationLock stay outside writer callbacks; IPC namespace is private and unchanged.",
"Public mapped guards stay inhibited; F proof and qualified E2 final exec remain required.",
"Every exact-head ci.yml job must succeed before approval."
],
"outcome": "same-head-needs-retry",
"proposed_fix_paths": [],
"resulting_head": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"review_observation_id": null,
"review_request_id": 6479609424,
"review_result_id": 6479650260,
"reviewed_head": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"root_cause": "Remote review clean and full exact-head local validation passed. Windows AMD64 job exceeded20m while reporting Run Go tests; logs unavailable. Bash evidence skipped downstream. No production defect or proven flake established. One bounded unchanged-head CI retry; no code edits or synchronization.",
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
},
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:56c7dd1e82b00445851a018fea660cdbb6c0f86c1e501912f4cc5ce79652ad5c",
"finding_ids": [],
"invariants": [
"Only exact owned immutable-image, complete kernel maps and pinned process/namespace evidence can admit native execution.",
"Durable native admission precedes one bounded release frame; no second release or ambiguous ownership cleanup.",
"Host observations that take OperationLock stay outside writer callbacks; IPC namespace is private and unchanged.",
"Public mapped guards stay inhibited; F proof and qualified E2 final exec remain required.",
"Every exact-head ci.yml job must succeed before approval."
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"review_observation_id": null,
"review_request_id": 6479609424,
"review_result_id": 6479650260,
"reviewed_head": "cbadc5ea29ca99de8b95349808ca71faae60ecb9",
"root_cause": "Unchanged E1.3 candidate; original exact-head clean Codex review reused after unchanged-head CI retry. All nine exact-head checks now successful. Complete five-command local validation refreshed after hotfix checkout and passed. No source fix, new finding or synchronization.",
"round": 2,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add invocation-owned inhibited Podman waiter startup with exact immutable-image, owner/peer, runtime and kernel process checks. Reuse the existing native admission writer before a single bounded framed stdin handoff; retain uncertain ownership and clean up only the exact created instance.
Preserve application stdin after the frame, keep admission deadlines separate from application lifetime, and reject missing proof, stale process evidence, unsupported streams and uncertain release. Add framing, real process/namespace and held-operation-lock callback tests. Public mapped execution remains inhibited; the qualified final exec transition and production storage/network admission remain E2/F gates.