Repository navigation
Skip focus restore in the dropdown when no target is found - #2490
Merged
Merged
Conversation
When a patch removed the focused element inside a dropdown and that element had no id, `id && querySelector(...)` evaluated to an empty string. Optional chaining only guards against null and undefined, so `""?.focus()` threw "focus is not a function" in the updated() callback.
Flo0807
force-pushed
the
fix/dropdown-focus-restore
branch
from
November 8, 2026 11:42
75f1c94 to
aac45a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BackpexDropdown.updated()restores focus to the element that had it before a patch. When the patch replaced that element and it had noid,this.focusedBeforeUpdate.id && this.el.querySelector(...)evaluates to"". Optional chaining only guards againstnull/undefined, so""?.focus()throws:We see this regularly in Sentry from an app using Backpex 0.23.0.
Fix
Only call
focus()when a target was found. A unit test intest/js/dropdown_test.jsreproduces the error ondevelop.