[lattln]

Summary

Addresses the shared Select defects tracked in #753 and reported in mieweb/eSheet#256:

• Safely handle empty search results for ArrowDown, ArrowUp, Home, End, and Enter without emitting an invalid selection.
• Keep popup DOM descendants within dialog/alertdialog focus and accessibility scope; use the browser top layer to preserve positioning in transformed dialogs.
• Re-query modal focus boundaries on Tab so dynamically opened search controls stay contained.
• Expose active options through aria-activedescendant on the trigger and searchable input, with matching consumer-facing documentation.
• Set explicit popup foreground colors and correct the dark-theme browser regression's token overrides to take precedence over Storybook brand styles.

Validation

• 37 Select unit tests passed, including no-match navigation, active-option associations, real-Modal Tab/Shift+Tab containment, and alertdialog scope.
• pnpm typecheck and full pnpm lint passed.
• Prettier validation and formatting passed for the three follow-up files.
• Integrated-browser assertions passed for dark popup/option colors, focused search within the dialog, and transformed-modal alignment (approximately 0.005 px error).
• The CLI Playwright runner could not launch Chrome in this environment; the relevant browser assertions were executed through the integrated browser instead.

Full downstream eSheet compose/upload integration and assistive-technology testing were not repeated during this follow-up. No npm release has been published by this update.

[Copilot]

🟡 Changes recommended

The Select portal still mispositions popups in transformed dialogs, allows focus to escape the modal when no options match, and excludes alertdialog containers from its scope lookup.

3 open issues

• Position popups relative to transformed dialog containers · New
• Include alertdialog elements in the modal scope lookup · New
• Re-query focusable elements to keep Tab within the modal · New

What changed in this PR

This PR addresses shared Select issues reported in mieweb/eSheet#256: keyboard handling after empty searches and popup containment within dialogs.

Changes:

• Guards empty-result navigation and selection against missing options.
• Targets the containing dialog for popup portals, with a body fallback.
• Adds keyboard and dialog-containment regressions and updates Storybook documentation.

File	Description
src/​components/​Select/​Select.tsx	Adds empty-result guards and dialog-scoped portal targeting.
src/​components/​Select/​Select.test.tsx	Adds no-match keyboard and modal popup containment tests.
src/​components/​Select/​Select.stories.tsx	Documents the revised portal behavior.

_{Review effort: Balanced}

[cloudflare-workers-and-pages]

Deploying ui with    Cloudflare Pages

Latest commit:	18e7e5f
Status:	✅  Deploy successful!
Preview URL:	https://2eda5c02.ui-6d0.pages.dev
Branch Preview URL:	https://fix-select-empty-modal-scope.ui-6d0.pages.dev

View logs

[Copilot]

🟡 Changes recommended

The popover’s default foreground overrides the dark theme’s text color, making unselected option labels black against a dark background; the panel needs an explicit foreground color and verification without Storybook’s dark color-scheme override.

1 open issue

• Set the popover panel foreground for dark themes · New

3 resolved since last review

• Re-query focusable elements to keep Tab within the modal
• Include alertdialog elements in the modal scope lookup
• Position popups relative to transformed dialog containers

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The new visual test’s token overrides lose to existing !important declarations, causing its color assertion to fail before the geometry regression check, and accessibility descriptions still contradict the implementation.

2 open issues

• Apply story token overrides with important priority · New
• Update outdated aria-activedescendant documentation · New

1 resolved since last review

• Set the popover panel foreground for dark themes

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Native-popover modal scope and active-option announcements still require human assistive-technology validation, since DOM relationships and focus assertions cannot establish screen-reader behavior.

No open issues 🎉

2 resolved since last review

• Apply story token overrides with important priority
• Update outdated aria-activedescendant documentation

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Native top-layer popup and active-descendant changes require human validation of screen-reader announcements and downstream integration beyond the supplied DOM and geometry assertions.

No open issues 🎉

_{Review effort: Balanced}