Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the UI dependency update and related Select regression-test changes.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Updates the workspace to @mieweb/ui@0.11.0-dev.69 to incorporate Select keyboard, modal-focus, and active-option accessibility fixes from mieweb/ui#752.
Changes:
- Aligns UI dependency versions across the workspace and refreshes the lockfile.
- Expands document workflow regression tests for navigation with no matching options and active-option accessibility attributes.
- Updates the README with the release version and upstream fix references.
| File | Description |
|---|---|
README.md |
Documents dev.69 and its upstream Select fixes. |
pnpm-lock.yaml |
Updates UI resolutions and package integrity to dev.69. |
packages/fields/package.json |
Aligns the fields package’s UI dependency. |
packages/fields-documents/src/DocumentListWorkflows.spec.tsx |
Adds empty-result keyboard and active-option accessibility assertions. |
packages/fields-documents/package.json |
Updates the documents package’s UI dependency. |
packages/field-health/package.json |
Aligns the health package’s UI dependency. |
packages/builder/package.json |
Aligns the builder’s UI dependency. |
package.json |
Updates the root UI dependency and workspace override. |
apps/demo/package.json |
Aligns the demo’s UI dependency. |
Review effort: Balanced
Deploying esheet with
|
| Latest commit: |
25b75b4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4ae43d0.esheet.pages.dev |
| Branch Preview URL: | https://ui-patch.esheet.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mieweb/ui@0.11.0-dev.69with the Select fixes from fix(Select): guard empty results and retain modal popup scope ui#752.Validation
376 tests passed; package build, workspace typecheck, targeted lint/formatting, and frozen-lockfile install passed.