Skip to content

test(evaluate): drop page timers from the overwritten Promise test #43439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 1 commit into from
Oct 15, 2026
+3 −2
Merged

test(evaluate): drop page timers from the overwritten Promise test #43439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/page/page-evaluate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,12 @@ it('should work with overwritten Promise', async ({ page }) => {

// Now, the new promise should be awaitable.
expect(await page.evaluate(() => Promise.resolve(42))).toBe(42);
const handle = await page.evaluateHandle(() => new Promise(f => setTimeout(() => f(42), 50)));
// No page timers below: the frozen-clock project never fires them.
const handle = await page.evaluateHandle(() => new Promise(f => queueMicrotask(() => f(42))));
expect(await handle.jsonValue()).toBe(42);
const error = await page.waitForFunction(() => false, undefined, { timeout: 500 }).catch(e => e);
expect(error.message).toContain('Timeout 500ms exceeded');
await page.evaluate(() => setTimeout(() => (window as any).__done = true, 50));
await page.evaluate(() => (window as any).__done = true);
await page.waitForFunction(() => (window as any).__done);
});

Expand Down
Loading